Skip to content

fix: OCI client, avoid calling tags/list if revision is not a constraint #23580 #23581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2025
Merged

fix: OCI client, avoid calling tags/list if revision is not a constraint #23580 #23581

merged 1 commit into from
Jun 26, 2025

Conversation

erdody
Copy link
Contributor

@erdody erdody commented Jun 26, 2025

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Fixes [ISSUE 23580] #23580

@erdody erdody requested a review from a team as a code owner June 26, 2025 20:10
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Jun 26, 2025 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@erdody
Copy link
Contributor Author

erdody commented Jun 26, 2025

cc @blakepettersson

@blakepettersson
Copy link
Member

@erdody nice optimization! I don't know why I didn't think of that...

Can you sign the DCO?

@erdody erdody force-pushed the fix-oci-no-tags-list branch from acbc6fb to c2809e7 Compare June 26, 2025 20:25
fix: OCI client, avoid calling tags/list if revision is not a constraint
ab50a03 
Signed-off-by: Diego Erdody <diego.erdody@dexterity.ai>
@erdody erdody force-pushed the fix-oci-no-tags-list branch from c2809e7 to ab50a03 Compare June 26, 2025 20:29
@erdody
Copy link
Contributor Author

erdody commented Jun 26, 2025

@erdody nice optimization! I don't know why I didn't think of that...

Can you sign the DCO?

Thanks. Yep, just did.

@codecov Codecov
Copy link

codecov bot commented Jun 26, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@986e1f8). Learn more about missing BASE report.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master   #23581   +/-   ##
=========================================
  Coverage          ?   60.23%           
=========================================
  Files             ?      345           
  Lines             ?    59097           
  Branches          ?        0           
=========================================
  Hits              ?    35596           
  Misses            ?    20627           
  Partials          ?     2874

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blakepettersson blakepettersson merged commit b8ac5ef into argoproj:master Jun 26, 2025
28 checks passed
@blakepettersson
Copy link
Member

/cherry-pick release-3.1

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jun 26, 2025
@erdody
fix: OCI client, avoid calling tags/list if revision is not a constra…
68a4427 
…int #23580 (#23581)

Signed-off-by: Diego Erdody <diego.erdody@dexterity.ai>
Co-authored-by: Diego Erdody <diego.erdody@dexterity.ai>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Jun 26, 2025
Merged
blakepettersson pushed a commit that referenced this pull request Jun 26, 2025
@gcp-cherry-pick-bot @erdody
fix: OCI client, avoid calling tags/list if revision is not a constra…
c215dbf 
…int #23580 (cherry-pick #23581) (#23582)

Signed-off-by: Diego Erdody <diego.erdody@dexterity.ai>
Co-authored-by: Diego Erdody <erdody@gmail.com>
Co-authored-by: Diego Erdody <diego.erdody@dexterity.ai>
@blakepettersson blakepettersson mentioned this pull request Jun 26, 2025
Closed
3 tasks
cjcocokrisp pushed a commit to cjcocokrisp/argo-cd that referenced this pull request Jun 27, 2025
@erdody @cjcocokrisp
fix: OCI client, avoid calling tags/list if revision is not a constra…
c743afd 
…int argoproj#23580 (argoproj#23581)

Signed-off-by: Diego Erdody <diego.erdody@dexterity.ai>
Co-authored-by: Diego Erdody <diego.erdody@dexterity.ai>
enneitex pushed a commit to enneitex/argo-cd that referenced this pull request Aug 24, 2025
@erdody @enneitex
fix: OCI client, avoid calling tags/list if revision is not a constra…
f550283 
…int argoproj#23580 (argoproj#23581)

Signed-off-by: Diego Erdody <diego.erdody@dexterity.ai>
Co-authored-by: Diego Erdody <diego.erdody@dexterity.ai>
Signed-off-by: enneitex <etienne.divet@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakepettersson blakepettersson blakepettersson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erdody @blakepettersson