Skip to content

fix(goreleaser): add darwin with CGO enabled to goreleaser #23433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 16, 2025
Merged

fix(goreleaser): add darwin with CGO enabled to goreleaser #23433

merged 2 commits into from
Jun 16, 2025

Conversation

rumstead
Copy link
Member

Since adding some azure auth libs we need to build the darwin cli with GCO enabled. To build the darwin cli, we need to enable it in goreleaser as well.

Broken build: https://github.com/argoproj/argo-cd/actions/runs/15688662314/job/44201821705

/cherry-pick release-3.0

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@rumstead
fix(goreleaser): add darwin with CGO enabled to gorelease
5e262dc 
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@rumstead rumstead requested review from a team as code owners June 16, 2025 20:17
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Jun 16, 2025 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

crenshaw-dev
crenshaw-dev reviewed Jun 16, 2025
View reviewed changes
@rumstead rumstead mentioned this pull request Jun 16, 2025
Closed
3 tasks
@codecov Codecov
Copy link

codecov bot commented Jun 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@ede2b32). Learn more about missing BASE report.
Report is 3 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master   #23433   +/-   ##
=========================================
  Coverage          ?   60.06%           
=========================================
  Files             ?      342           
  Lines             ?    58799           
  Branches          ?        0           
=========================================
  Hits              ?    35319           
  Misses            ?    20625           
  Partials          ?     2855

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) June 16, 2025 21:08
@crenshaw-dev crenshaw-dev merged commit 0b8d018 into argoproj:master Jun 16, 2025
28 checks passed
@rumstead
Copy link
Member Author

/cherry-pick release-3.0

@gcp-cherry-pick-bot GCP Cherry-Pick Bot
Copy link

Cherry-pick failed with Merge error 0b8d018fdfd13b92c455478eede3dcc0048f562a into temp-cherry-pick-39582d-release-3.0

This was referenced Jun 16, 2025
Merged
Merged
enneitex pushed a commit to enneitex/argo-cd that referenced this pull request Aug 24, 2025
@rumstead @enneitex
fix(goreleaser): add darwin with CGO enabled to goreleaser (argoproj#…
1e94a0b 
…23433)

Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
Signed-off-by: enneitex <etienne.divet@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rumstead @crenshaw-dev