Skip to content

fix(applicationset): requeue applicationste when application status changes #23412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2025
Merged

fix(applicationset): requeue applicationste when application status changes #23412

merged 1 commit into from
Jun 16, 2025

Conversation

rumstead
Copy link
Member

…(#23043)

Cherry picking #23043

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@dshmelev @rumstead
fix(applicationset_controller): requeue by ApplicationStatus changes (a…
6498558 
…rgoproj#23043)

Signed-off-by: Dmitry Shmelev <Dmitry.Shmelev@jetbrains.com>
Signed-off-by: Dmitry Shmelev <avikez@gmail.com>
Co-authored-by: rumstead <37445536+rumstead@users.noreply.github.com>
@rumstead rumstead requested a review from a team as a code owner June 16, 2025 14:42
@rumstead rumstead changed the title fix(applicationset_controller): requeue by ApplicationStatus changes … fix(applicationset): requeue applicationste when application status changes Jun 16, 2025
@codecov Codecov
Copy link

codecov bot commented Jun 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.94%. Comparing base (d89e34b) to head (6498558).
Report is 1 commits behind head on release-3.0.

Additional details and impacted files 
@@               Coverage Diff               @@
##           release-3.0   #23412      +/-   ##
===============================================
- Coverage        55.94%   55.94%   -0.01%     
===============================================
  Files              343      343              
  Lines            57430    57434       +4     
===============================================
+ Hits             32128    32129       +1     
+ Misses           22653    22650       -3     
- Partials          2649     2655       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev crenshaw-dev merged commit 3ab884f into argoproj:release-3.0 Jun 16, 2025
22 of 23 checks passed
@rumstead rumstead deleted the cherry-pick-25dc960-to-release-3.0 branch June 16, 2025 15:53
@riuvshyn riuvshyn mentioned this pull request Jun 19, 2025
Closed
3 tasks
@rumstead rumstead mentioned this pull request Jul 29, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rumstead @crenshaw-dev @dshmelev