Skip to content

fix(goreleaser): add darwin with CGO enabled and remove static to gorelease #23457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 17, 2025
Merged

fix(goreleaser): add darwin with CGO enabled and remove static to gorelease #23457

merged 3 commits into from
Jun 17, 2025

Conversation

rumstead
Copy link
Member

@rumstead rumstead commented Jun 17, 2025 •
edited
Loading 

❯ goreleaser check
  • checking                                 path=.goreleaser.yaml
  • 1 configuration file(s) validated
  • thanks for using GoReleaser!


❯ GIT_TREE_STATE=clean KUBECTL_VERSION=1 goreleaser build --snapshot --skip before --clean
  • skipping before and validate...
  • cleaning distribution directory
  • loading environment variables
  • getting and validating git state
    • git state                                      commit=902826f8c79ab0f7a7baaa295460d4c401481bc3 branch=HEAD current_tag=v3.0.8 previous_tag=v3.0.7 dirty=true
    • pipe skipped or partially skipped              reason=disabled during snapshot mode
  • parsing tag
  • setting defaults
  • snapshotting
    • building snapshot...                           version=2.6.0
  • ensuring distribution directory
  • setting up metadata
  • writing release metadata
  • loading go mod information
  • build prerequisites
  • building binaries
    • building                                       binary=dist/argocd-cli_darwin_arm64_v8.0/argocd-darwin-arm64
    • building                                       binary=dist/argocd-cli_linux_s390x/argocd-linux-s390x
    • building                                       binary=dist/argocd-cli_windows_amd64_v1/argocd-windows-amd64.exe
    • building                                       binary=dist/argocd-cli_linux_ppc64le_power8/argocd-linux-ppc64le
    • building                                       binary=dist/argocd-cli_linux_amd64_v1/argocd-linux-amd64
    • building                                       binary=dist/argocd-cli_linux_arm64_v8.0/argocd-linux-arm64
    • building                                       binary=dist/argocd-cli_darwin_amd64_v1/argocd-darwin-amd64
    • overridden build details for darwin_amd64_v1   details={ [-X github.com/argoproj/argo-cd/v3/common.version={{ .Version }} -X github.com/argoproj/argo-cd/v3/common.buildDate={{ .Date }} -X github.com/argoproj/argo-cd/v3/common.gitCommit={{ .FullCommit }} -X github.com/argoproj/argo-cd/v3/common.gitTreeState={{ .Env.GIT_TREE_STATE }} -X github.com/argoproj/argo-cd/v3/common.kubectlVersion={{ .Env.KUBECTL_VERSION }} {{ if or (eq .Runtime.Goos "linux") (eq .Runtime.Goos "windows") }}-extldflags="-static"{{ end }}] [] [-v] [] [] [CGO_ENABLED=1]}
    • overridden build details for darwin_arm64_v8.0 details={ [-X github.com/argoproj/argo-cd/v3/common.version={{ .Version }} -X github.com/argoproj/argo-cd/v3/common.buildDate={{ .Date }} -X github.com/argoproj/argo-cd/v3/common.gitCommit={{ .FullCommit }} -X github.com/argoproj/argo-cd/v3/common.gitTreeState={{ .Env.GIT_TREE_STATE }} -X github.com/argoproj/argo-cd/v3/common.kubectlVersion={{ .Env.KUBECTL_VERSION }} {{ if or (eq .Runtime.Goos "linux") (eq .Runtime.Goos "windows") }}-extldflags="-static"{{ end }}] [] [-v] [] [] [CGO_ENABLED=1]}

...
   • took: 3m31s
  • writing artifacts metadata
  • build succeeded after 3m32s
  • thanks for using GoReleaser!

❯ ls -1 ./dist 
argocd-cli_darwin_amd64_v1
argocd-cli_darwin_arm64_v8.0
argocd-cli_linux_amd64_v1
argocd-cli_linux_arm64_v8.0
argocd-cli_linux_ppc64le_power8
argocd-cli_linux_s390x
argocd-cli_windows_amd64_v1

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

rumstead added 2 commits June 17, 2025 14:21
@rumstead
fix(goreleaser): add darwin with CGO enabled and remove static to gor…
f3f8178 
…elease

Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@rumstead
fix(goreleaser): add darwin with CGO enabled and remove static to gor…
c986a6e 
…elease

Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@rumstead rumstead requested review from a team as code owners June 17, 2025 18:22
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Jun 17, 2025 •
edited
Loading

❌ Preview Environment undeployed from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

rumstead
rumstead commented Jun 17, 2025
View reviewed changes
@rumstead rumstead enabled auto-merge (squash) June 17, 2025 18:41
@rumstead rumstead merged commit 8ede222 into argoproj:master Jun 17, 2025
40 of 42 checks passed
@rumstead
Copy link
Member Author

/cherry-pick release-3.0

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jun 17, 2025
@rumstead
fix(goreleaser): add darwin with CGO enabled and remove static to gor…
7e1682e 
…elease (#23457)

Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Jun 17, 2025
Merged
@rumstead rumstead deleted the fix/goreleaser-darwin branch June 17, 2025 20:32
rumstead added a commit that referenced this pull request Jun 17, 2025
@gcp-cherry-pick-bot @rumstead
fix(goreleaser): add darwin with CGO enabled and remove static to gor…
8868f91 
…elease (cherry-pick #23457) (#23459)

Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
Co-authored-by: rumstead <37445536+rumstead@users.noreply.github.com>
@agaudreault
Copy link
Member

Seems like this is possibly not working es expected https://github.com/argoproj/argo-cd/actions/runs/15763098995/job/44435046442

@rumstead
Copy link
Member Author

It’s not. We have to build it on a Darwin VM or install the Darwin C headers

https://cloud-native.slack.com/archives/C020XM04CUW/p1750102742561109

@yashuatla yashuatla mentioned this pull request Jun 25, 2025
Open
enneitex pushed a commit to enneitex/argo-cd that referenced this pull request Aug 24, 2025
@rumstead @enneitex
fix(goreleaser): add darwin with CGO enabled and remove static to gor…
58b583b 
…elease (argoproj#23457)

Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
Signed-off-by: enneitex <etienne.divet@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rumstead @agaudreault @crenshaw-dev