Skip to content

fix(appset): Add token to enterprise client (#23240) #23455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2025
Merged

fix(appset): Add token to enterprise client (#23240) #23455

merged 1 commit into from
Jun 18, 2025

Conversation

lets-call-n-walk
Copy link
Contributor

@lets-call-n-walk lets-call-n-walk commented Jun 17, 2025 •
edited
Loading

A change in how the token was passed, resulted in forgetting to pass the token to the enterprise client in the Pull Request Generator.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Jun 17, 2025 •
edited
Loading

❌ Preview Environment undeployed from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@crenshaw-dev crenshaw-dev changed the title Fixes [#23240]: Add token to enterprise client fix(appset): Add token to enterprise client (#23240) Jun 17, 2025
@codecov Codecov
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 60.21%. Comparing base (fa25f27) to head (2a4bc12).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
applicationset/services/pull_request/github.go 40.00% 1 Missing and 2 partials ⚠️
applicationset/services/scm_provider/github.go 40.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #23455   +/-   ##
=======================================
  Coverage   60.21%   60.21%           
=======================================
  Files         343      343           
  Lines       59047    59055    +8     
=======================================
+ Hits        35553    35559    +6     
+ Misses      20645    20636    -9     
- Partials     2849     2860   +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pass token to enterprise
87cbea5 
Signed-off-by: Collin Walker <cwalker@ancestry.com>
@lets-call-n-walk lets-call-n-walk force-pushed the pass-token-to-enterprise branch from 2a4bc12 to 87cbea5 Compare June 17, 2025 21:14
@lets-call-n-walk
Copy link
Contributor Author

we have built/tested this in our production and it fixed the issue

@lets-call-n-walk lets-call-n-walk marked this pull request as ready for review June 17, 2025 21:38
@lets-call-n-walk lets-call-n-walk requested a review from a team as a code owner June 17, 2025 21:38
gdsoumya
gdsoumya approved these changes Jun 18, 2025
View reviewed changes
Copy link
Member

@gdsoumya gdsoumya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the fix.

@gdsoumya gdsoumya merged commit f7590fa into argoproj:master Jun 18, 2025
29 checks passed
@lets-call-n-walk
Copy link
Contributor Author

lets-call-n-walk commented Jun 18, 2025 •
edited
Loading

@gdsoumya Do you know when this will be released (and what release)?

@gdsoumya
Copy link
Member

This will need to be back ported to release branch and then eventually released with future patch releases. I don't have an eta atm

@gdsoumya
Copy link
Member

/cherry-pick release-3.0

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jun 18, 2025
@lets-call-n-walk
fix(appset): Add token to enterprise client (#23240) (#23455)
e8b1f01 
Signed-off-by: Collin Walker <cwalker@ancestry.com>
Co-authored-by: Collin Walker <cwalker@ancestry.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Jun 18, 2025
Merged
gdsoumya pushed a commit that referenced this pull request Jun 18, 2025
@gcp-cherry-pick-bot @lets-call-n-walk
fix(appset): Add token to enterprise client (#23240) (cherry-pick #23455
be3e940 
) (#23476)

Signed-off-by: Collin Walker <cwalker@ancestry.com>
Co-authored-by: Collin Walker <10523817+lets-call-n-walk@users.noreply.github.com>
Co-authored-by: Collin Walker <cwalker@ancestry.com>
cjcocokrisp pushed a commit to cjcocokrisp/argo-cd that referenced this pull request Jun 24, 2025
@lets-call-n-walk @cjcocokrisp
fix(appset): Add token to enterprise client (argoproj#23240) (argopro…
2c8c79a 
…j#23455)

Signed-off-by: Collin Walker <cwalker@ancestry.com>
Co-authored-by: Collin Walker <cwalker@ancestry.com>
@yashuatla yashuatla mentioned this pull request Jun 25, 2025
Open
enneitex pushed a commit to enneitex/argo-cd that referenced this pull request Aug 24, 2025
@lets-call-n-walk @enneitex
fix(appset): Add token to enterprise client (argoproj#23240) (argopro…
98956cb 
…j#23455)

Signed-off-by: Collin Walker <cwalker@ancestry.com>
Co-authored-by: Collin Walker <cwalker@ancestry.com>
Signed-off-by: enneitex <etienne.divet@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdsoumya gdsoumya gdsoumya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lets-call-n-walk @gdsoumya