Skip to content

fix: Add metadata labels to all NetworkPolicy resources #23313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jun 7, 2025
Merged

fix: Add metadata labels to all NetworkPolicy resources #23313

merged 13 commits into from
Jun 7, 2025

Conversation

philippemerle
Copy link
Contributor

@philippemerle philippemerle commented Jun 7, 2025 •
edited
Loading

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

In manifests/base, all Kubernetes resources have metadata labels defined, except for all NetworkPolicy resources, as illustrated in the following architecture diagrams generated with KubeDiagrams:

base-original

This should be an oversight, shouldn't it?

This PR adds metadata labels to all NetworkPolicy resources, as illustrated in the following architecture diagrams generated with KubeDiagrams:

base-corrected

@philippemerle philippemerle requested a review from a team as a code owner June 7, 2025 06:09
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Jun 7, 2025 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@codecov Codecov
Copy link

codecov bot commented Jun 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.90%. Comparing base (7915002) to head (368df90).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #23313      +/-   ##
==========================================
- Coverage   59.96%   59.90%   -0.06%     
==========================================
  Files         342      342              
  Lines       58573    58573              
==========================================
- Hits        35123    35089      -34     
- Misses      20604    20636      +32     
- Partials     2846     2848       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippemerle philippemerle changed the title Add metadata labels to all NetworkPolicy resources fix: Add metadata labels to all NetworkPolicy resources Jun 7, 2025
crenshaw-dev and others added 11 commits June 7, 2025 10:22
@crenshaw-dev @philippemerle
chore: bump gitops-engine for error wrapping (argoproj#23282)
482c36f 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Philippe Merle <philippe.merle@inria.fr>
@dependabot @philippemerle
chore(deps): bump google.golang.org/grpc from 1.72.2 to 1.73.0 (argop…
e8de2e6 
…roj#23292)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Philippe Merle <philippe.merle@inria.fr>
@crenshaw-dev @philippemerle
fix(metrics): populate dest_server label (argoproj#23246) (argoproj#2…
1338d0c 
…3269)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Philippe Merle <philippe.merle@inria.fr>
@HarHarLinks @crenshaw-dev @philippemerle
docs: spelling, formatting, etc updates (argoproj#23306)
5489a31 
Signed-off-by: Kim Brose <2803622+HarHarLinks@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Philippe Merle <philippe.merle@inria.fr>
@crenshaw-dev @philippemerle
fix(server): race condition in revoked token logic (argoproj#23311) (a…
d49153c 
…rgoproj#23312)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Philippe Merle <philippe.merle@inria.fr>
@philippemerle
Add metadata labels to all NetworkPolicy resources
3bd47f4 
Signed-off-by: Philippe Merle <philippe.merle@inria.fr>
@philippemerle
Revert "Add metadata labels to all NetworkPolicy resources"
a23f204 
This reverts commit 518311c.

Signed-off-by: Philippe Merle <philippe.merle@inria.fr>
@philippemerle
Add metadata labels to all NetworkPolicy resources
e9e8cec 
Signed-off-by: Philippe Merle <philippe.merle@inria.fr>
@philippemerle
Update generated manifests
b0957ec 
Signed-off-by: Philippe Merle <philippe.merle@inria.fr>
@philippemerle
Revert "Add metadata labels to all NetworkPolicy resources"
fd42f13 
This reverts commit 518311c.

Signed-off-by: Philippe Merle <philippe.merle@inria.fr>
@philippemerle
Add metadata labels to all NetworkPolicy resources
c065ca4 
Signed-off-by: Philippe Merle <philippe.merle@inria.fr>
@philippemerle philippemerle requested a review from a team as a code owner June 7, 2025 08:23
gdsoumya
gdsoumya approved these changes Jun 7, 2025
View reviewed changes
Copy link
Member

@gdsoumya gdsoumya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crenshaw-dev crenshaw-dev merged commit edf3683 into argoproj:master Jun 7, 2025
28 checks passed
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
@philippemerle @crenshaw-dev
@dependabot @HarHarLinks @dsuhinin
fix: Add metadata labels to all NetworkPolicy resources (argoproj#23313)
eac4054 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Philippe Merle <philippe.merle@inria.fr>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Kim Brose <2803622+HarHarLinks@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kim Brose <2803622+HarHarLinks@users.noreply.github.com>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
@philippemerle @crenshaw-dev
@dependabot @HarHarLinks @dsuhinin
fix: Add metadata labels to all NetworkPolicy resources (argoproj#23313)
4cf3d39 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Philippe Merle <philippe.merle@inria.fr>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Kim Brose <2803622+HarHarLinks@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kim Brose <2803622+HarHarLinks@users.noreply.github.com>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
enneitex pushed a commit to enneitex/argo-cd that referenced this pull request Aug 24, 2025
@philippemerle @crenshaw-dev
@dependabot @HarHarLinks @enneitex
fix: Add metadata labels to all NetworkPolicy resources (argoproj#23313)
d7bf6bd 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Philippe Merle <philippe.merle@inria.fr>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Kim Brose <2803622+HarHarLinks@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kim Brose <2803622+HarHarLinks@users.noreply.github.com>
Signed-off-by: enneitex <etienne.divet@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdsoumya gdsoumya gdsoumya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@philippemerle @gdsoumya @crenshaw-dev @HarHarLinks