Skip to content

fix(metrics): populate dest_server label (#23246) (#23269) #23308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2025
Merged

fix(metrics): populate dest_server label (#23246) (#23269) #23308

merged 1 commit into from
Jun 6, 2025

Conversation

crenshaw-dev
Copy link
Member

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@crenshaw-dev
fix(metrics): populate dest_server label (argoproj#23246) (argoproj#2…
fe64ed7 
…3269)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@codecov Codecov
Copy link

codecov bot commented Jun 6, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.90909% with 4 lines in your changes missing coverage. Please review.

Project coverage is 55.97%. Comparing base (59d4519) to head (fe64ed7).
Report is 2 commits behind head on release-3.0.

Files with missing lines Patch % Lines
controller/metrics/metrics.go 85.71% 2 Missing and 1 partial ⚠️
cmd/argocd/commands/admin/app.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##           release-3.0   #23308      +/-   ##
===============================================
+ Coverage        55.91%   55.97%   +0.06%     
===============================================
  Files              343      343              
  Lines            57435    57460      +25     
===============================================
+ Hits             32114    32165      +51     
+ Misses           22667    22653      -14     
+ Partials          2654     2642      -12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev crenshaw-dev marked this pull request as ready for review June 6, 2025 18:54
@crenshaw-dev crenshaw-dev requested a review from a team as a code owner June 6, 2025 18:54
@crenshaw-dev crenshaw-dev merged commit fc271d4 into argoproj:release-3.0 Jun 6, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agaudreault agaudreault agaudreault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crenshaw-dev @agaudreault