Skip to content

Conversation

crenshaw-dev
Copy link
Member

The history of the master branch is littered with incomplete CI runs. That has a couple downsides:

  1. It's more difficult to determine which commit broke the build
  2. Codecov reports don't always get sent to Codecov, so coverage reports for PRs often just say "no HEAD to compare"

Now that we're on the CNCF enterprise account and are allotted an absurd number of parallel runners, I think we can afford to run all CI jobs on every commit to master.

If we have trouble, we can always revisit.

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev crenshaw-dev requested review from a team as code owners June 13, 2025 21:08
Copy link

bunnyshell bot commented Jun 13, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@96fd061). Learn more about missing BASE report.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #23392   +/-   ##
=========================================
  Coverage          ?   60.07%           
=========================================
  Files             ?      342           
  Lines             ?    58805           
  Branches          ?        0           
=========================================
  Hits              ?    35327           
  Misses            ?    20624           
  Partials          ?     2854           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev crenshaw-dev merged commit 64198e8 into argoproj:master Jun 14, 2025
28 checks passed
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
jcogilvie pushed a commit to Sanyaku/argo-cd that referenced this pull request Jun 16, 2025
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Jonathan Ogilvie <jonathan.ogilvie@sumologic.com>
enneitex pushed a commit to enneitex/argo-cd that referenced this pull request Aug 24, 2025
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: enneitex <etienne.divet@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants