Skip to content

feat(hydrator): commit tracing (#19441) #23361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jun 13, 2025
Merged

feat(hydrator): commit tracing (#19441) #23361

merged 13 commits into from
Jun 13, 2025

Conversation

crenshaw-dev
Copy link
Member

Closes #19441

@crenshaw-dev
feat(hydrator): commit tracing (argoproj#19441)
51539be 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Jun 11, 2025 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@agaudreault agaudreault added this to the v3.1 milestone Jun 11, 2025
agaudreault
agaudreault reviewed Jun 11, 2025
View reviewed changes
agaudreault
agaudreault reviewed Jun 11, 2025
View reviewed changes
@crenshaw-dev
fix nil ref error
b82add2 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@codecov Codecov
Copy link

codecov bot commented Jun 12, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.27451% with 21 lines in your changes missing coverage. Please review.

Project coverage is 59.98%. Comparing base (44fce0e) to head (6bea5cd).
Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
controller/hydrator/hydrator.go 63.63% 8 Missing and 4 partials ⚠️
util/git/client.go 92.00% 4 Missing and 2 partials ⚠️
reposerver/repository/repository.go 88.88% 1 Missing and 1 partial ⚠️
commitserver/commit/hydratorhelper.go 96.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #23361      +/-   ##
==========================================
+ Coverage   59.95%   59.98%   +0.03%     
==========================================
  Files         342      342              
  Lines       58660    58792     +132     
==========================================
+ Hits        35168    35268     +100     
- Misses      20639    20656      +17     
- Partials     2853     2868      +15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev
more flexible structure
fac577f 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev
tests
3149895 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev
lint
1a286d3 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev crenshaw-dev marked this pull request as ready for review June 12, 2025 19:43
@crenshaw-dev crenshaw-dev requested review from a team as code owners June 12, 2025 19:43
zachaller
zachaller reviewed Jun 12, 2025
View reviewed changes
agaudreault
agaudreault reviewed Jun 12, 2025
View reviewed changes
agaudreault
agaudreault reviewed Jun 12, 2025
View reviewed changes
agaudreault
agaudreault reviewed Jun 12, 2025
View reviewed changes
agaudreault
agaudreault reviewed Jun 12, 2025
View reviewed changes
agaudreault
agaudreault reviewed Jun 12, 2025
View reviewed changes
agaudreault
agaudreault reviewed Jun 12, 2025
View reviewed changes
andrii-korotkov
andrii-korotkov reviewed Jun 13, 2025
View reviewed changes
@crenshaw-dev
support multiline commit body, add more validation, add more tests
25753b3 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev
Merge remote-tracking branch 'origin/master' into commit-tracing
4ae4a23 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev
revert temporary change
6db3e99 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev
rename field
1457a0f 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev
docs fixes
71e5f86 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this to Ready for final review in Argo CD Review Jun 13, 2025
@crenshaw-dev
fix test
bad04c5 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
agaudreault
agaudreault reviewed Jun 13, 2025
View reviewed changes
@crenshaw-dev
Merge remote-tracking branch 'origin/master' into commit-tracing
b92ea0c 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev
Merge remote-tracking branch 'origin/master' into commit-tracing
6bea5cd 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
crenshaw-dev commented Jun 13, 2025
View reviewed changes
commitserver/commit/hydratorhelper_test.go
Comment on lines +107 to +108
assert.Equal(t, metadata.Author, topMetadata.Author)
assert.Equal(t, metadata.Message, topMetadata.Message)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: add assertion for top-level date field

@agaudreault agaudreault merged commit 81ae77a into argoproj:master Jun 13, 2025
28 checks passed
@crenshaw-dev crenshaw-dev deleted the commit-tracing branch June 13, 2025 19:28
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
@crenshaw-dev @dsuhinin
feat(hydrator): commit tracing (argoproj#19441) (argoproj#23361)
60d5e03 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
jcogilvie pushed a commit to Sanyaku/argo-cd that referenced this pull request Jun 16, 2025
@crenshaw-dev @jcogilvie
feat(hydrator): commit tracing (argoproj#19441) (argoproj#23361)
1b5b357 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Jonathan Ogilvie <jonathan.ogilvie@sumologic.com>
enneitex pushed a commit to enneitex/argo-cd that referenced this pull request Aug 24, 2025
@crenshaw-dev @enneitex
feat(hydrator): commit tracing (argoproj#19441) (argoproj#23361)
cb89e6d 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: enneitex <etienne.divet@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachaller zachaller zachaller left review comments

@agaudreault agaudreault agaudreault approved these changes

+1 more reviewer

@andrii-korotkov andrii-korotkov andrii-korotkov approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
for-release-blog-3-1
Projects
Argo CD Review
Archived in project
Milestone
v3.1
Development

Successfully merging this pull request may close these issues.

hydrator: design a way to link manifest changes to code changes
4 participants
@crenshaw-dev @zachaller @andrii-korotkov @agaudreault