Skip to content

feat: remove suspended state from numaproj crds #23359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 12, 2025
Merged

feat: remove suspended state from numaproj crds #23359

merged 2 commits into from
Jun 12, 2025
+14 −10

Conversation

dpadhiar
Copy link
Member

@dpadhiar dpadhiar commented Jun 11, 2025 •
edited
Loading

This PR removes the Suspended state from all Numaproj CRDs when they are in the Paused phase. We consider this state Healthy from now on to prevent the entire application from appearing as Suspended.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@dpadhiar
feat: remove suspended state from numaproj crds
d3a4f77 
Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Jun 11, 2025 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@codecov Codecov
Copy link

codecov bot commented Jun 11, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@dbd8009). Learn more about missing BASE report.
Report is 4 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master   #23359   +/-   ##
=========================================
  Coverage          ?   59.91%           
=========================================
  Files             ?      342           
  Lines             ?    58605           
  Branches          ?        0           
=========================================
  Hits              ?    35114           
  Misses            ?    20635           
  Partials          ?     2856

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dpadhiar dpadhiar marked this pull request as ready for review June 11, 2025 18:41
@dpadhiar dpadhiar requested a review from a team as a code owner June 11, 2025 18:41
@ishitasequeira ishitasequeira merged commit 5091f9a into argoproj:master Jun 12, 2025
29 checks passed
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
@dpadhiar @dsuhinin
feat: remove suspended state from numaproj crds (argoproj#23359)
2860b06 
Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
enneitex pushed a commit to enneitex/argo-cd that referenced this pull request Aug 24, 2025
@dpadhiar @enneitex
feat: remove suspended state from numaproj crds (argoproj#23359)
a66a206 
Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Signed-off-by: enneitex <etienne.divet@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdsoumya gdsoumya gdsoumya approved these changes

@ishitasequeira ishitasequeira ishitasequeira approved these changes

@nitishfy nitishfy nitishfy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dpadhiar @gdsoumya @ishitasequeira @nitishfy