fix(sync): auto-sync loop when FailOnSharedResource #23357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-2.14 #23357 +/- ##
================================================
+ Coverage 55.31% 55.35% +0.04%
================================================
Files 339 339
Lines 57374 57373 -1
================================================
+ Hits 31735 31760 +25
+ Misses 22942 22926 -16
+ Partials 2697 2687 -10 ☔ View full report in Codecov by Sentry. |
|
/cherry-pick release-3.0 |
|
Cherry-pick failed with |
agaudreault
added a commit
to agaudreault/argo-cd
that referenced
this pull request
Jul 2, 2025
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
agaudreault
added a commit
to agaudreault/argo-cd
that referenced
this pull request
Jul 2, 2025
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
agaudreault
added a commit
to agaudreault/argo-cd
that referenced
this pull request
Jul 2, 2025
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
agaudreault
added a commit
that referenced
this pull request
Jul 2, 2025
agaudreault
added a commit
that referenced
this pull request
Jul 2, 2025
agaudreault
added a commit
that referenced
this pull request
Jul 2, 2025
dsuhinin
pushed a commit
to dsuhinin/argo-cd
that referenced
this pull request
Jul 9, 2025
…rgoproj#23641) Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
enneitex
pushed a commit
to enneitex/argo-cd
that referenced
this pull request
Aug 24, 2025
…rgoproj#23641) Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Signed-off-by: enneitex <etienne.divet@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a loop when auto-sync is on and the application is configured to
FailOnSharedResource.Auto-sync will try to compare the revisions in the sync results. However, the syncResult is not initialized on errors returned this early in SyncAppState.
In general, the errors happening early are validation also performed before auto-sync runs, but not in this case.
The real fix to prevent this from happening is #23356