chore(refactor): sync operations state and multi-source handling #23356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23356 +/- ##
==========================================
- Coverage 60.17% 60.09% -0.08%
==========================================
Files 346 346
Lines 59295 59248 -47
==========================================
- Hits 35680 35608 -72
- Misses 20748 20770 +22
- Partials 2867 2870 +3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
…ared-resource-master Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com> Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
crenshaw-dev
requested changes
Jun 27, 2025
This was referenced Jul 1, 2025
…ared-resource-master Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
crenshaw-dev
requested changes
Jul 14, 2025
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
crenshaw-dev
approved these changes
Jul 16, 2025
3 tasks
enneitex
pushed a commit
to enneitex/argo-cd
that referenced
this pull request
Aug 24, 2025
…nc loop (argoproj#23356) Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Signed-off-by: enneitex <etienne.divet@gmail.com>
downfa11
pushed a commit
to downfa11/argo-cd
that referenced
this pull request
Aug 25, 2025
…nc loop (argoproj#23356) Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactor how the sources and revisions are handled during the sync. Multi-source feature and individual bugfixes added complexity to the code that makes it hard to understand and can be simplified.
Multiple refractors and previous bugfixes are linked to this PR and were prerequisites for this refactor.
This PR relates to some of recent code changes made to self heal and sync logic.