Skip to content

chore: upgrade Go from 1.24.3 to 1.24.4 #23287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2025
Merged

chore: upgrade Go from 1.24.3 to 1.24.4 #23287

merged 1 commit into from
Jun 6, 2025

Conversation

thevilledev
Copy link
Contributor

Updates Go version across all workflows, Dockerfiles and go.mod.

See:

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@thevilledev thevilledev requested review from a team as code owners June 6, 2025 03:38
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Jun 6, 2025 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

crenshaw-dev
crenshaw-dev approved these changes Jun 6, 2025
View reviewed changes
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@thevilledev thevilledev mentioned this pull request Jun 6, 2025
Merged
14 tasks
@crenshaw-dev crenshaw-dev enabled auto-merge (squash) June 6, 2025 03:46
@thevilledev thevilledev mentioned this pull request Jun 6, 2025
Merged
14 tasks
auto-merge was automatically disabled June 6, 2025 03:54

Head branch was pushed to by a user without write access

@thevilledev thevilledev force-pushed the chore/master-go-1.24.4 branch from f129ce7 to 4134e05 Compare June 6, 2025 03:54
@thevilledev
Copy link
Contributor Author

Dependabot updated test/remote/Dockerfile already so I excluded it from this PR #23286

@codecov Codecov
Copy link

codecov bot commented Jun 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.00%. Comparing base (9472273) to head (daae70d).
Report is 5 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #23287   +/-   ##
=======================================
  Coverage   60.00%   60.00%           
=======================================
  Files         341      341           
  Lines       57818    57818           
=======================================
+ Hits        34694    34695    +1     
+ Misses      20344    20340    -4     
- Partials     2780     2783    +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blakepettersson
Copy link
Member

@thevilledev I think it's fine to add the Dockerfile to your PR, we can just close the Dependabot one

@thevilledev
chore: upgrade Go from 1.24.3 to 1.24.4
daae70d 
Updates Go version across all workflows, Dockerfiles and go.mod

Signed-off-by: Ville Vesilehto <ville@vesilehto.fi>
@thevilledev thevilledev force-pushed the chore/master-go-1.24.4 branch from 4134e05 to daae70d Compare June 6, 2025 08:20
blakepettersson
blakepettersson approved these changes Jun 6, 2025
View reviewed changes
Copy link
Member

@blakepettersson blakepettersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blakepettersson blakepettersson merged commit e1195fd into argoproj:master Jun 6, 2025
28 checks passed
@blakepettersson
Copy link
Member

/cherry-pick release-3.0

@gcp-cherry-pick-bot GCP Cherry-Pick Bot
Copy link

Cherry-pick failed with Merge error e1195fd931979b620375064cb3054bf0fb08c3ed into temp-cherry-pick-09b851-release-3.0

dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
@thevilledev @dsuhinin
chore: upgrade Go from 1.24.3 to 1.24.4 (argoproj#23287)
c1a5ee6 
Signed-off-by: Ville Vesilehto <ville@vesilehto.fi>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
@thevilledev @dsuhinin
chore: upgrade Go from 1.24.3 to 1.24.4 (argoproj#23287)
a11a6b8 
Signed-off-by: Ville Vesilehto <ville@vesilehto.fi>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
enneitex pushed a commit to enneitex/argo-cd that referenced this pull request Aug 24, 2025
@thevilledev @enneitex
chore: upgrade Go from 1.24.3 to 1.24.4 (argoproj#23287)
de66aa2 
Signed-off-by: Ville Vesilehto <ville@vesilehto.fi>
Signed-off-by: enneitex <etienne.divet@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

@blakepettersson blakepettersson blakepettersson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thevilledev @blakepettersson @crenshaw-dev