Skip to content

fix: parse project with applicationset resource #23252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2025
Merged

fix: parse project with applicationset resource #23252

merged 1 commit into from
Jun 4, 2025
+42 −6

Conversation

blakepettersson
Copy link
Member

@blakepettersson blakepettersson commented Jun 4, 2025 •
edited
Loading

Performing appset actions are supposed to work when used in a project, but up until now did not when called via the API. That is due to the applicationset RBAC resource not being accounted for when the request was parsed.

Should be cherry-picked to 3.0 and 2.14.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@blakepettersson
fix: parse project with applicationset resource
96f416d 
Applicationsets are supposed to work when used in a project, but up until
now did not when called via the API. That is due to the RBAC action not
being present when the request was parsed.

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
@blakepettersson blakepettersson requested a review from a team as a code owner June 4, 2025 09:03
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Jun 4, 2025 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@codecov Codecov
Copy link

codecov bot commented Jun 4, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 60.06%. Comparing base (18ce5c2) to head (96f416d).
⚠️ Report is 438 commits behind head on master.

Files with missing lines Patch % Lines
server/rbacpolicy/rbacpolicy.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #23252      +/-   ##
==========================================
+ Coverage   59.98%   60.06%   +0.07%     
==========================================
  Files         343      341       -2     
  Lines       57890    57865      -25     
==========================================
+ Hits        34727    34756      +29     
+ Misses      20381    20339      -42     
+ Partials     2782     2770      -12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nitishfy
nitishfy approved these changes Jun 4, 2025
View reviewed changes
Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blakepettersson blakepettersson merged commit f532299 into argoproj:master Jun 4, 2025
29 checks passed
@blakepettersson
Copy link
Member Author

/cherry-pick release-3.0

@blakepettersson
Copy link
Member Author

/cherry-pick release-2.14

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jun 4, 2025
@blakepettersson
fix: parse project with applicationset resource (#23252)
095f487 
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Jun 4, 2025
Merged
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jun 4, 2025
@blakepettersson
fix: parse project with applicationset resource (#23252)
a3b079d 
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Jun 4, 2025
Merged
blakepettersson added a commit that referenced this pull request Jun 5, 2025
@gcp-cherry-pick-bot @blakepettersson
fix: parse project with applicationset resource (cherry-pick #23252) (#…
a31d5c9 
…23267)

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
blakepettersson added a commit that referenced this pull request Jun 5, 2025
@gcp-cherry-pick-bot @blakepettersson
fix: parse project with applicationset resource (cherry-pick #23252) (#…
14fa0e0 
…23268)

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
@blakepettersson @dsuhinin
fix: parse project with applicationset resource (argoproj#23252)
679f84f 
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
@blakepettersson @dsuhinin
fix: parse project with applicationset resource (argoproj#23252)
d369581 
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
@blakepettersson blakepettersson deleted the fix/parse-project-with-applicationset-actions branch June 24, 2025 21:20
@log1cb0mb log1cb0mb mentioned this pull request Jul 15, 2025
Open
3 tasks
enneitex pushed a commit to enneitex/argo-cd that referenced this pull request Aug 24, 2025
@blakepettersson @enneitex
fix: parse project with applicationset resource (argoproj#23252)
a05a2c9 
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: enneitex <etienne.divet@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdsoumya gdsoumya gdsoumya approved these changes

@nitishfy nitishfy nitishfy approved these changes

+1 more reviewer

@christianh814 christianh814 christianh814 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blakepettersson @christianh814 @gdsoumya @nitishfy