feat(ui): set validate=false for "disable autosync" request during rollback via ui (#22898) #23101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st during rollback via ui Signed-off-by: 이드로 (Jethro Lee) <dlemfh96@gmail.com>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
| @@ -1205,7 +1205,7 @@ Are you sure you want to disable auto-sync and rollback application '${this.prop | |||
| if (needDisableRollback) { | |||
| const update = JSON.parse(JSON.stringify(application)) as appModels.Application; | |||
| update.spec.syncPolicy.automated = null; | |||
| await services.applications.update(update); | |||
| await services.applications.update(update, {validate: false}); | |||
There was a problem hiding this comment.
Consider adding a comment explaining why skipping validation is desired here.
agaudreault
approved these changes
Jun 4, 2025
dsuhinin
pushed a commit
to dsuhinin/argo-cd
that referenced
this pull request
Jun 16, 2025
…llback via ui (argoproj#22898) (argoproj#23101) Signed-off-by: 이드로 (Jethro Lee) <dlemfh96@gmail.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
dsuhinin
pushed a commit
to dsuhinin/argo-cd
that referenced
this pull request
Jun 16, 2025
…llback via ui (argoproj#22898) (argoproj#23101) Signed-off-by: 이드로 (Jethro Lee) <dlemfh96@gmail.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
enneitex
pushed a commit
to enneitex/argo-cd
that referenced
this pull request
Aug 24, 2025
…llback via ui (argoproj#22898) (argoproj#23101) Signed-off-by: 이드로 (Jethro Lee) <dlemfh96@gmail.com> Signed-off-by: enneitex <etienne.divet@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution to half of #22898, submitting as guided by @agaudreault, thanks!! 🤗
Description
This PR sets
?validate=falsefor thePUT applicationrequest that is made when user clicks rollback in UI.When validate is true (the default), a full rebuild of kustomize build may be triggered because of cache invalidation.
Since the intention of the
PUT applicationrequest is just to switch off auto-sync, there is no need to re-validate the app spec and trigger a kustomize build.This behavior is consistent with the fact that the frontend already adds
?validate=falseto PUT requests triggered via theENABLE AUTO-SYNCandDISABLE AUTO-SYNCbuttons in the application details UI:argo-cd/ui/src/app/applications/components/application-summary/application-summary.tsx
Line 386 in 9183506
Testing
We've been using this cherry picked build in production, and can confirm works well as intended!
Please let me know if you prefer some test code be accompanied as well.
Checklist:
Does this PR require documentation updates?I've updated documentation as required by this PR.