Skip to content

feat: implement custom resource action skip-current-step for argo rollouts #23025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 18, 2025
Merged

feat: implement custom resource action skip-current-step for argo rollouts #23025

merged 3 commits into from
May 18, 2025

Conversation

reggie-k
Copy link
Member

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@reggie-k
implement skip current action for argo rollouts
9f5ffff 
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
@reggie-k reggie-k requested a review from a team as a code owner May 18, 2025 07:03
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented May 18, 2025 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@reggie-k reggie-k changed the title feat: implement custom resource action skip-current-test for argo rollouts feat: implement custom resource action skip-current-step for argo rollouts May 18, 2025
@reggie-k
implement skip current action for argo rollouts
e982a06 
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
@reggie-k reggie-k requested a review from a team as a code owner May 18, 2025 07:12
@codecov Codecov
Copy link

codecov bot commented May 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.04%. Comparing base (f763b2a) to head (5cf63ec).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #23025      +/-   ##
==========================================
+ Coverage   59.99%   60.04%   +0.05%     
==========================================
  Files         343      343              
  Lines       57846    57846              
==========================================
+ Hits        34704    34736      +32     
+ Misses      20362    20343      -19     
+ Partials     2780     2767      -13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reggie-k
resolved conflicts
5cf63ec 
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
@pasha-codefresh pasha-codefresh merged commit ec9b43f into argoproj:master May 18, 2025
27 checks passed
ranakan19 pushed a commit to ranakan19/argo-cd that referenced this pull request May 20, 2025
@reggie-k @ranakan19
feat: implement custom resource action skip-current-step for argo rol…
9e4c52a 
…louts (argoproj#23025)

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Signed-off-by: Kanika Rana <krana@redhat.com>
olivergondza pushed a commit to olivergondza/argo-cd that referenced this pull request May 20, 2025
@reggie-k @olivergondza
feat: implement custom resource action skip-current-step for argo rol…
76296eb 
…louts (argoproj#23025)

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
LyhengTep pushed a commit to LyhengTep/argo-cd that referenced this pull request May 24, 2025
@reggie-k @LyhengTep
feat: implement custom resource action skip-current-step for argo rol…
a66cc55 
…louts (argoproj#23025)

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Signed-off-by: Lyheng <lyhengtep@gmail.com>
tylerrosnett pushed a commit to StateFarmIns/argo-cd that referenced this pull request May 27, 2025
@reggie-k @tylerrosnett
feat: implement custom resource action skip-current-step for argo rol…
9b8237a 
…louts (argoproj#23025)

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
chansuke pushed a commit to chansuke/argo-cd that referenced this pull request Jun 4, 2025
@reggie-k @chansuke
feat: implement custom resource action skip-current-step for argo rol…
f04d6c6 
…louts (argoproj#23025)

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
@reggie-k reggie-k deleted the rollouts-skip-current-step-custom-action branch June 15, 2025 12:13
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
@reggie-k @dsuhinin
feat: implement custom resource action skip-current-step for argo rol…
d16b9b2 
…louts (argoproj#23025)

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
@reggie-k @dsuhinin
feat: implement custom resource action skip-current-step for argo rol…
a2cfe08 
…louts (argoproj#23025)

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasha-codefresh pasha-codefresh pasha-codefresh approved these changes

+1 more reviewer

@pkostohrys pkostohrys pkostohrys approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reggie-k @pkostohrys @pasha-codefresh