Skip to content

fix(azure): use compatible workload identity modules #23004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 11, 2025
Merged

fix(azure): use compatible workload identity modules #23004

merged 10 commits into from
Jun 11, 2025

Conversation

rumstead
Copy link
Member

@rumstead rumstead commented May 15, 2025 •
edited
Loading

closes #22884 maybe

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@rumstead
fix(azure): use compatible workload identity modules
9a24036 
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@rumstead rumstead requested a review from a team as a code owner May 15, 2025 20:38
rumstead
rumstead commented May 15, 2025
View reviewed changes
go.mod Outdated
@@ -5,8 +5,8 @@ go 1.24.1
require (
code.gitea.io/sdk/gitea v0.20.0
dario.cat/mergo v1.0.1
github.com/Azure/azure-sdk-for-go/sdk/azcore v1.17.0
github.com/Azure/azure-sdk-for-go/sdk/azidentity v1.8.2
github.com/Azure/azure-sdk-for-go/sdk/azcore v1.14.0
Copy link
Member Author

@rumstead rumstead May 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these match what kubelogin v0.1.9 was built with https://github.com/Azure/kubelogin/blob/9b6ecad1a09cb72d5cd1ad266ac6977553a67811/go.mod#L7

rumstead
rumstead commented May 15, 2025
View reviewed changes
go.mod Outdated
@@ -130,7 +130,7 @@ require (
github.com/Azure/go-autorest/autorest/date v0.3.0 // indirect
github.com/Azure/go-autorest/logger v0.2.1 // indirect
github.com/Azure/go-autorest/tracing v0.6.0 // indirect
github.com/AzureAD/microsoft-authentication-library-for-go v1.3.3 // indirect
github.com/AzureAD/microsoft-authentication-library-for-go v1.2.2 // indirect
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also matches kubelogin v0.1.9

https://github.com/Azure/kubelogin/blob/9b6ecad1a09cb72d5cd1ad266ac6977553a67811/go.mod#L11

rumstead and others added 6 commits May 16, 2025 09:43
@rumstead
Retrigger CI pipeline
8ccdf21 
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@rumstead
Merge branch 'release-3.0' into fix/workload-identity
56d72ba
@rumstead
Retrigger CI pipeline
fef89af 
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@rumstead
Merge branch 'fix/workload-identity' of github.com:rumstead/argo-cd i…
c893a9f 
…nto fix/workload-identity
@rumstead
please be nice to me
05bc7d0 
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@crenshaw-dev
Merge branch 'release-3.0' into fix/workload-identity
8b7b167
@codecov Codecov
Copy link

codecov bot commented May 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.93%. Comparing base (db93798) to head (2b9689f).
Report is 1 commits behind head on release-3.0.

Additional details and impacted files 
@@               Coverage Diff               @@
##           release-3.0   #23004      +/-   ##
===============================================
+ Coverage        55.91%   55.93%   +0.01%     
===============================================
  Files              343      343              
  Lines            57430    57430              
===============================================
+ Hits             32111    32122      +11     
+ Misses           22667    22654      -13     
- Partials          2652     2654       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MaxAnderson95
Copy link

Hi @crenshaw-dev is it possible to get this PR reviewed?

@rumstead
Copy link
Member Author

Folks have said that the latest versions on HEAD work. Should we use those instead?

@MaxAnderson95
Copy link

Folks have said that the latest versions on HEAD work. Should we use those instead?

Yeah it looks like the version in HEAD are:

github.com/Azure/azure-sdk-for-go/sdk/azcore v1.18.0
github.com/Azure/azure-sdk-for-go/sdk/azidentity v1.10.0
github.com/Azure/kubelogin v0.2.8

compared to the tag v3.0.5

github.com/Azure/azure-sdk-for-go/sdk/azcore v1.17.0
github.com/Azure/azure-sdk-for-go/sdk/azidentity v1.8.2
github.com/Azure/kubelogin v0.1.9

rumstead added 3 commits June 10, 2025 11:57
@rumstead
update az libs to HEAD version
232a849 
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@rumstead
update az libs to HEAD version
bd0eb14 
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
@rumstead
Merge branch 'release-3.0' into fix/workload-identity
2b9689f
@crenshaw-dev crenshaw-dev merged commit d89e34b into argoproj:release-3.0 Jun 11, 2025
21 of 22 checks passed
@rumstead rumstead deleted the fix/workload-identity branch June 11, 2025 16:27
@MaxAnderson95 MaxAnderson95 mentioned this pull request Jun 13, 2025
Closed
3 tasks
@rumstead
Copy link
Member Author

/cherry-pick release-2.14

@rumstead
Copy link
Member Author

/cherry-pick release-3.0

@gcp-cherry-pick-bot GCP Cherry-Pick Bot
Copy link

Cherry-pick failed with Merge error d89e34b900b478aef44f9a113214f704ee793c51 into temp-cherry-pick-ca714e-release-2.14

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jun 16, 2025
@rumstead @crenshaw-dev
fix(azure): use compatible workload identity modules (#23004)
b9ee20a 
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Jun 16, 2025
Closed
@rumstead
Copy link
Member Author

oops... just need to cut a release 😮‍💨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rumstead @MaxAnderson95 @crenshaw-dev