Skip to content

chore: replace heptio-images with argocd-e2e-container (cherry-pick #23040) #23056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2025
Merged

chore: replace heptio-images with argocd-e2e-container (cherry-pick #23040) #23056

merged 1 commit into from
May 27, 2025

Conversation

nitishfy
Copy link
Member

@nitishfy nitishfy commented May 20, 2025 •
edited
Loading

Cherry-pick #23040

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@nitishfy nitishfy requested review from a team as code owners May 20, 2025 09:03
@nitishfy
fix unit test
b981ee1 
Signed-off-by: nitishfy <justnitish06@gmail.com>
@nitishfy nitishfy force-pushed the images-cherry-pick-2.13 branch from d355166 to b981ee1 Compare May 20, 2025 13:54
@codecov Codecov
Copy link

codecov bot commented May 20, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.07%. Comparing base (4b11800) to head (b981ee1).
⚠️ Report is 9 commits behind head on release-2.13.

Files with missing lines Patch % Lines
cmd/argocd/commands/admin/app.go 0.00% 1 Missing ⚠️
cmd/argocd/commands/app.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##           release-2.13   #23056   +/-   ##
=============================================
  Coverage         55.07%   55.07%           
=============================================
  Files               320      320           
  Lines             54856    54858    +2     
=============================================
+ Hits              30210    30214    +4     
+ Misses            22058    22056    -2     
  Partials           2588     2588

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reggie-k reggie-k merged commit 6612b7b into argoproj:release-2.13 May 27, 2025
22 of 23 checks passed
@nitishfy nitishfy deleted the images-cherry-pick-2.13 branch May 27, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reggie-k reggie-k reggie-k approved these changes

@rumstead rumstead rumstead approved these changes

@ishitasequeira ishitasequeira ishitasequeira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nitishfy @reggie-k @rumstead @ishitasequeira