fix(server): infer resource status health for apps-in-any-ns #22944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #22944 +/- ##
=======================================
Coverage 60.00% 60.00%
=======================================
Files 343 343
Lines 57821 57821
=======================================
+ Hits 34694 34698 +4
+ Misses 20356 20345 -11
- Partials 2771 2778 +7 ☔ View full report in Codecov by Sentry. |
rumstead
approved these changes
May 22, 2025
LyhengTep
pushed a commit
to LyhengTep/argo-cd
that referenced
this pull request
May 24, 2025
…j#22944) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Lyheng <lyhengtep@gmail.com>
tylerrosnett
pushed a commit
to StateFarmIns/argo-cd
that referenced
this pull request
May 27, 2025
…j#22944) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
chansuke
pushed a commit
to chansuke/argo-cd
that referenced
this pull request
Jun 4, 2025
…j#22944) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
dsuhinin
pushed a commit
to dsuhinin/argo-cd
that referenced
this pull request
Jun 16, 2025
…j#22944) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
dsuhinin
pushed a commit
to dsuhinin/argo-cd
that referenced
this pull request
Jun 16, 2025
…j#22944) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
3 tasks
|
Hi @crenshaw-dev , Could this one be cherry-picked to 3.0 ? |
14 tasks
|
/cherry-pick release-3.1 |
|
/cherry-pick release-3.0 |
|
/cherry-pick release-2.14 |
|
It there an issue with the cherry pick bot ? |
crenshaw-dev
added a commit
that referenced
this pull request
Jul 9, 2025
crenshaw-dev
added a commit
that referenced
this pull request
Jul 9, 2025
rumstead
pushed a commit
that referenced
this pull request
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cache key will include the app namespace if the app is outside the controller namespace.