Skip to content

Conversation

sabre1041
Copy link
Contributor

Improvements to Helm related documentation

  • Removed statement that a repository secret is required to use an OCI based Helm chart
  • Expanded usage within private repositories
  • Added declarative Helm examples
    • Use within an Application
    • OCI based Charts

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: Andrew Block <andy.block@gmail.com>
@sabre1041 sabre1041 requested review from a team as code owners May 4, 2025 02:50
Copy link

bunnyshell bot commented May 4, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link
Member

@csantanapr csantanapr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with comments


Non standard Helm Chart repositories have to be registered explicitly.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this not longer a requirement? Since which version of Argo CD?
I think I remember if I didn't register the public ECR (no auth required) to install karpenter from the OCI registry it didn't work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure the specific version support was introduced, but its no longer needed

namespace: nginx
```

Helm charts located in sources that require additional configuration, such as authentication or TLS connection details, are defined within a _repository_ Secret. Each Secret must specify the `url`, `type` and `name` fields. Additional fields including `username`, `password`, `tlsClientCertData` and `tlsClientCertKey` can be specified as desired.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can provide a link on what repository Secret is, which I'm assuming your referring a Secret with a label argocd.argoproj.io/secret-type: repository

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. If you look further down, you will see an example with the appropriate label

Copy link
Member

@blakepettersson blakepettersson May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we just highlight that name is really important to add when using Helm dependencies?

(the real question is why having name is a requirement for Helm dependencies rather than just filtering by url in the repo server but that's another story...)

@@ -1138,6 +1169,23 @@ stringData:
tlsClientCertKey: ...
```

Helm charts sourced from OCI registries should utilize the fields described previously as well as set the `enableOCI` field as `true`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So glad we are documenting this, I had an end user I support recently asking me where is the enableOCI documented.


1. Navigate to `Settings/Repositories`

![connect repo overview](../assets/repo-add-overview.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, that you added a picture for this.

```

!!! note
The protocol, such as `oci://` should be omitted when referencing an OCI registry
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mentioned, that this prefix is reserved for future support of OCI native?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not until the new feature is made available. At that time, we can denote the differences and intended capabilities

@ishitasequeira ishitasequeira self-requested a review May 8, 2025 14:05
Copy link
Member

@blakepettersson blakepettersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor question/point, otherwise LGTM

@blakepettersson blakepettersson merged commit 4a15925 into argoproj:master May 31, 2025
23 checks passed
chansuke pushed a commit to chansuke/argo-cd that referenced this pull request Jun 4, 2025
Signed-off-by: Andrew Block <andy.block@gmail.com>
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
Signed-off-by: Andrew Block <andy.block@gmail.com>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
Signed-off-by: Andrew Block <andy.block@gmail.com>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
enneitex pushed a commit to enneitex/argo-cd that referenced this pull request Aug 24, 2025
Signed-off-by: Andrew Block <andy.block@gmail.com>
Signed-off-by: enneitex <etienne.divet@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants