Skip to content

feat: Implement healthcheck gateway api (#20986) #22855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 12, 2025
Merged

feat: Implement healthcheck gateway api (#20986) #22855

merged 7 commits into from
Jun 12, 2025

Conversation

chansuke
Copy link
Contributor

@chansuke chansuke commented May 3, 2025

Closes #20986

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@chansuke
feat: implement Healthchecks for Gateway API resources
0a80b48 
Signed-off-by: chansuke <moonset20@gmail.com>
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented May 3, 2025 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@chansuke chansuke changed the title feat: implement healthcheck gateway api (#20986) feat: Implement healthcheck gateway api (#20986) May 3, 2025
@codecov Codecov
Copy link

codecov bot commented May 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@0e95193). Learn more about missing BASE report.
Report is 53 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master   #22855   +/-   ##
=========================================
  Coverage          ?   60.06%           
=========================================
  Files             ?      341           
  Lines             ?    57865           
  Branches          ?        0           
=========================================
  Hits              ?    34759           
  Misses            ?    20328           
  Partials          ?     2778

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chansuke chansuke marked this pull request as ready for review May 3, 2025 07:48
@chansuke chansuke requested a review from a team as a code owner May 3, 2025 07:48
crenshaw-dev
crenshaw-dev previously requested changes May 21, 2025
View reviewed changes
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Added a couple requests for tests of nil checks. If those fields aren't actually nillable, we can skip those.

@crenshaw-dev crenshaw-dev added this to the v3.1 milestone May 21, 2025
@chansuke
feat: add testings for nil guard
7243fb1 
Signed-off-by: chansuke <moonset20@gmail.com>
@chansuke chansuke force-pushed the feat/healthcheck-gateway-api branch from d2f0033 to 7243fb1 Compare May 24, 2025 07:02
@chansuke chansuke requested a review from crenshaw-dev May 24, 2025 10:13
@agaudreault agaudreault enabled auto-merge (squash) June 12, 2025 20:43
@agaudreault agaudreault merged commit a2152a1 into argoproj:master Jun 12, 2025
28 checks passed
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
@chansuke @dsuhinin
feat: Implement healthcheck gateway api (argoproj#20986) (argoproj#22855
c61ae39 
)

Signed-off-by: chansuke <moonset20@gmail.com>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
jcogilvie pushed a commit to Sanyaku/argo-cd that referenced this pull request Jun 16, 2025
@chansuke @jcogilvie
feat: Implement healthcheck gateway api (argoproj#20986) (argoproj#22855
96f8c20 
)

Signed-off-by: chansuke <moonset20@gmail.com>
Signed-off-by: Jonathan Ogilvie <jonathan.ogilvie@sumologic.com>
enneitex pushed a commit to enneitex/argo-cd that referenced this pull request Aug 24, 2025
@chansuke @enneitex
feat: Implement healthcheck gateway api (argoproj#20986) (argoproj#22855
4f8c813 
)

Signed-off-by: chansuke <moonset20@gmail.com>
Signed-off-by: enneitex <etienne.divet@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agaudreault agaudreault agaudreault approved these changes

@crenshaw-dev crenshaw-dev Awaiting requested review from crenshaw-dev

Assignees
No one assigned
Labels
component:health-check
Projects
None yet
Milestone
v3.1
Development

Successfully merging this pull request may close these issues.

Healthchecks for Gateway API resources
3 participants
@chansuke @crenshaw-dev @agaudreault