Skip to content

feat: Contour HTTPProxy health check support for issue # 22504 #22596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 21, 2025
Merged

feat: Contour HTTPProxy health check support for issue # 22504 #22596

merged 6 commits into from
May 21, 2025

Conversation

gregbarasch
Copy link
Contributor

@gregbarasch gregbarasch commented Apr 8, 2025 •
edited
Loading

Fixes #22504
This adds simple health checks for Contour HTTPProxy objects

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Apr 8, 2025 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@codecov Codecov
Copy link

codecov bot commented Apr 8, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.85%. Comparing base (362dc66) to head (f94f073).
⚠️ Report is 542 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #22596   +/-   ##
=======================================
  Coverage   59.84%   59.85%           
=======================================
  Files         344      344           
  Lines       57715    57715           
=======================================
+ Hits        34541    34546    +5     
- Misses      20402    20405    +3     
+ Partials     2772     2764    -8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

davinci26
davinci26 reviewed Apr 8, 2025
View reviewed changes
resource_customizations/projectcontour.io/HTTPProxy/health.lua
else
hs.status = "Degraded"
end
hs.message = obj.status.description
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the message used for anything?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah -- this is what is returned to ArgoCD, and it links back with:

type HealthStatus struct {
	Status  HealthStatusCode `json:"status,omitempty"`
	Message string           `json:"message,omitempty"`
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/argoproj/gitops-engine/blob/master/pkg/health/health.go#L37

@davinci26
Copy link

Fixes #22504

@gregbarasch gregbarasch changed the title This is a pass at adding Contour HTTPProxy health check support feat: Contour HTTPProxy health check support May 5, 2025
gregbarasch added 2 commits May 5, 2025 18:58
@gregbarasch
This is a pass at adding Contour HTTPProxy health check support
b2b890a 
Signed-off-by: Greg Barasch <gregbarasch@gmail.com>
@gregbarasch
Small test rework
9eb0f75 
Signed-off-by: Greg Barasch <gregbarasch@gmail.com>
@gregbarasch gregbarasch force-pushed the contour-httpproxy-healthcheck-lua branch from 671a7b9 to 9eb0f75 Compare May 5, 2025 23:00
@gregbarasch
invalid rollsback rather than NotReconciled
957a4d9 
Signed-off-by: Greg Barasch <gregbarasch@gmail.com>
@gregbarasch gregbarasch changed the title feat: Contour HTTPProxy health check support feat: Contour HTTPProxy health check support for issue # 22504 May 5, 2025
@gregbarasch
Copy link
Contributor Author

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • ❌ /bns:delete to remove the environment

/bns:start

@gregbarasch
description is updated regardless of valid, invalid, unknown.
8d5c511 
Signed-off-by: Greg Barasch <gregbarasch@gmail.com>
@gregbarasch gregbarasch marked this pull request as ready for review May 6, 2025 00:01
@gregbarasch gregbarasch requested a review from a team as a code owner May 6, 2025 00:01
crenshaw-dev
crenshaw-dev approved these changes May 21, 2025
View reviewed changes
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A future iteration could pull the error messages and add them to the health message, but this at least gets the party started. :-) Thanks!

@crenshaw-dev crenshaw-dev merged commit ce4b7a2 into argoproj:master May 21, 2025
27 checks passed
LyhengTep pushed a commit to LyhengTep/argo-cd that referenced this pull request May 24, 2025
@gregbarasch @LyhengTep
feat: Contour HTTPProxy health check support for issue # 22504 (argop…
3cd3544 
…roj#22596)

Signed-off-by: Greg Barasch <gregbarasch@gmail.com>
Signed-off-by: Lyheng <lyhengtep@gmail.com>
tylerrosnett pushed a commit to StateFarmIns/argo-cd that referenced this pull request May 27, 2025
@gregbarasch @tylerrosnett
feat: Contour HTTPProxy health check support for issue # 22504 (argop…
ad47729 
…roj#22596)

Signed-off-by: Greg Barasch <gregbarasch@gmail.com>
chansuke pushed a commit to chansuke/argo-cd that referenced this pull request Jun 4, 2025
@gregbarasch @chansuke
feat: Contour HTTPProxy health check support for issue # 22504 (argop…
35379c7 
…roj#22596)

Signed-off-by: Greg Barasch <gregbarasch@gmail.com>
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
@gregbarasch @dsuhinin
feat: Contour HTTPProxy health check support for issue # 22504 (argop…
24e6a9b 
…roj#22596)

Signed-off-by: Greg Barasch <gregbarasch@gmail.com>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
@gregbarasch @dsuhinin
feat: Contour HTTPProxy health check support for issue # 22504 (argop…
7c1b851 
…roj#22596)

Signed-off-by: Greg Barasch <gregbarasch@gmail.com>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

+2 more reviewers

@davinci26 davinci26 davinci26 left review comments

@christianh814 christianh814 christianh814 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
component:health-check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Contour/HTTPProxy resource health
4 participants
@gregbarasch @davinci26 @crenshaw-dev @christianh814