Skip to content

fix: update field name from syncPolicy.automated.enable to enabled #22440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 24, 2025
Merged

fix: update field name from syncPolicy.automated.enable to enabled #22440

merged 2 commits into from
Mar 24, 2025

Conversation

anandrkskd
Copy link
Contributor

@anandrkskd anandrkskd commented Mar 21, 2025 •
edited
Loading

Update field name spec.syncPolicy.automated.enable to follow naming standard as stated in the attached issue, it will make the naming more streamlined with previously created similar fields.

fixes: #22439

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@anandrkskd anandrkskd requested review from a team as code owners March 21, 2025 20:48
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Mar 21, 2025 •
edited
Loading

❌ Preview Environment undeployed from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@anandrkskd anandrkskd mentioned this pull request Mar 21, 2025
Merged
14 tasks
nitishfy
nitishfy requested changes Mar 23, 2025
View reviewed changes
Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are failing. Can you make sure to pass the required checks?

@anandrkskd
update field name from enable to enabled
8af308d 
update field name spec.syncPolicy.automated.enable to follow naming standard

Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com>
@anandrkskd
fix failing tests
22b60fe 
Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com>
@anandrkskd anandrkskd force-pushed the enchancement-update-enable-to-enabled branch from 57c9377 to 22b60fe Compare March 24, 2025 06:48
@anandrkskd anandrkskd changed the title update field name from syncPolicy.automated.enable to enabled fix: update field name from syncPolicy.automated.enable to enabled Mar 24, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.90%. Comparing base (a628db9) to head (22b60fe).
Report is 445 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #22440      +/-   ##
==========================================
+ Coverage   55.88%   55.90%   +0.02%     
==========================================
  Files         343      343              
  Lines       57333    57333              
==========================================
+ Hits        32038    32051      +13     
+ Misses      22650    22640      -10     
+ Partials     2645     2642       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ishitasequeira
ishitasequeira approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ishitasequeira ishitasequeira merged commit fe347e3 into argoproj:master Mar 24, 2025
30 of 32 checks passed
Hapshanko pushed a commit to Hapshanko/argo-cd that referenced this pull request Apr 29, 2025
@anandrkskd @Hapshanko
fix: update field name from syncPolicy.automated.enable to enabled (a…
ce2dc76 
…rgoproj#22440)

Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com>
Signed-off-by: Hapshanko <adamgaming391100@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitishfy nitishfy nitishfy requested changes

@ishitasequeira ishitasequeira ishitasequeira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update enable field to enabled for automatedSync policy
3 participants
@anandrkskd @ishitasequeira @nitishfy