-
Notifications
You must be signed in to change notification settings - Fork 6.4k
chore: simplify user agent version constraint handling in interceptors #22358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
fcd67fb
to
c16c1f3
Compare
c16c1f3
to
72d2e61
Compare
c58be4d
to
39a6288
Compare
e4e7d67
to
3a967f6
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22358 +/- ##
=======================================
Coverage 56.03% 56.04%
=======================================
Files 343 343
Lines 57568 57569 +1
=======================================
+ Hits 32258 32263 +5
+ Misses 22659 22656 -3
+ Partials 2651 2650 -1 ☔ View full report in Codecov by Sentry. |
15bdbc5
to
d2874ae
Compare
/cc @crenshaw-dev |
aa25e38
to
7fcdf76
Compare
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
7fcdf76
to
c0cf633
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall change looks good to me!!
argoproj#22358) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> Signed-off-by: Lyheng <lyhengtep@gmail.com>
argoproj#22358) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
argoproj#22358) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
argoproj#22358) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
argoproj#22358) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
Description
simplify user agent version constraint handling in interceptors