Skip to content

Conversation

mmorel-35
Copy link
Contributor

Description

simplify user agent version constraint handling in interceptors

@mmorel-35 mmorel-35 requested a review from a team as a code owner March 15, 2025 10:35
Copy link

bunnyshell bot commented Mar 15, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@mmorel-35 mmorel-35 force-pushed the user-agent-validator branch from fcd67fb to c16c1f3 Compare March 15, 2025 10:40
@mmorel-35 mmorel-35 changed the title refactor: simplify user agent version constraint handling in interceptors feat: simplify user agent version constraint handling in interceptors Mar 15, 2025
@mmorel-35 mmorel-35 force-pushed the user-agent-validator branch from c16c1f3 to 72d2e61 Compare March 15, 2025 10:42
@mmorel-35 mmorel-35 changed the title feat: simplify user agent version constraint handling in interceptors chore: simplify user agent version constraint handling in interceptors Mar 15, 2025
@mmorel-35 mmorel-35 force-pushed the user-agent-validator branch 2 times, most recently from c58be4d to 39a6288 Compare March 15, 2025 14:35
@mmorel-35 mmorel-35 force-pushed the user-agent-validator branch 4 times, most recently from e4e7d67 to 3a967f6 Compare March 18, 2025 08:07
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

❌ Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.04%. Comparing base (ffe4225) to head (c0cf633).
⚠️ Report is 663 commits behind head on master.

Files with missing lines Patch % Lines
util/grpc/useragent.go 22.22% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #22358   +/-   ##
=======================================
  Coverage   56.03%   56.04%           
=======================================
  Files         343      343           
  Lines       57568    57569    +1     
=======================================
+ Hits        32258    32263    +5     
+ Misses      22659    22656    -3     
+ Partials     2651     2650    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmorel-35 mmorel-35 force-pushed the user-agent-validator branch 4 times, most recently from 15bdbc5 to d2874ae Compare March 24, 2025 22:02
@mmorel-35
Copy link
Contributor Author

/cc @crenshaw-dev
Would you mind having a look ?

@mmorel-35 mmorel-35 force-pushed the user-agent-validator branch 2 times, most recently from aa25e38 to 7fcdf76 Compare March 28, 2025 07:01
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 force-pushed the user-agent-validator branch from 7fcdf76 to c0cf633 Compare March 31, 2025 13:38
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall change looks good to me!!

@crenshaw-dev crenshaw-dev merged commit 17e03ff into argoproj:master May 21, 2025
27 checks passed
@mmorel-35 mmorel-35 deleted the user-agent-validator branch May 21, 2025 21:21
LyhengTep pushed a commit to LyhengTep/argo-cd that referenced this pull request May 24, 2025
argoproj#22358)

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Lyheng <lyhengtep@gmail.com>
tylerrosnett pushed a commit to StateFarmIns/argo-cd that referenced this pull request May 27, 2025
argoproj#22358)

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
chansuke pushed a commit to chansuke/argo-cd that referenced this pull request Jun 4, 2025
argoproj#22358)

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
argoproj#22358)

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
dsuhinin pushed a commit to dsuhinin/argo-cd that referenced this pull request Jun 16, 2025
argoproj#22358)

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants