-
Notifications
You must be signed in to change notification settings - Fork 6.3k
feat!: update compareoptions default values #22230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: update compareoptions default values #22230
Conversation
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22230 +/- ##
==========================================
+ Coverage 55.82% 55.84% +0.01%
==========================================
Files 342 342
Lines 57213 57215 +2
==========================================
+ Hits 31940 31951 +11
+ Misses 22639 22628 -11
- Partials 2634 2636 +2 ☔ View full report in Codecov by Sentry. |
in `resource.customizations` key of the `argocd-cm` ConfigMap. | ||
|
||
Following is an example of a customization which ignores the `refreshTime` status field of an [`ExternalSecret`](https://external-secrets.io/main/api/externalsecret/) resource: | ||
|
||
```yaml | ||
data: | ||
resource.customizations.ignoreResourceUpdates.external-secrets.io_ExternalSecret: | | ||
resource.customizations.ignoreResourceUpdates.external-secrets.io_ExternalSecret: | ||
| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Signed-off-by: Hapshanko <adamgaming391100@gmail.com>
Description