Skip to content

fix(appcontroller): if a history limit is negative, automatically converted to 0 #22036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
May 8, 2025
Merged

fix(appcontroller): if a history limit is negative, automatically converted to 0 #22036

merged 15 commits into from
May 8, 2025

Conversation

kingbj940429
Copy link
Contributor

@kingbj940429 kingbj940429 commented Feb 26, 2025 •
edited
Loading

Related to #21691

There are two Expected Behaviors

  1. A readable error message pointing out that negative values are not allowed.
  2. Silently interpreting the revisionHistoryLimit as 0.

I choose num 2.

Before

image
image

After

image
image

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@kingbj940429 kingbj940429 requested a review from a team as a code owner February 26, 2025 17:02
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Feb 26, 2025 •
edited
Loading

❗ Preview Environment undeploy from Bunnyshell failed

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🚀 /bns:deploy to redeploy the environment
  • ❌ /bns:delete to try again to remove the environment

kingbj940429 and others added 11 commits February 27, 2025 02:09
@kingbj940429
WIP on master
37d429a 
fix(appcontroller): if a history limit is negative, automatically converted to 0

Signed-off-by: kingbj0429 <kingbj0429@lunit.io>
@rumstead @ishitasequeira
@blakepettersson @kingbj940429
fix(appset): generated app errors should use the default requeue (arg…
c3bef5e 
…oproj#21887) (argoproj#21936)

Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: kingbj0429 <kingbj0429@lunit.io>
@agaudreault @kingbj940429
chore(deps): bump go 1.23.5 & tools (argoproj#21748)
5d88902 
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: kingbj0429 <kingbj0429@lunit.io>
@reggie-k @rumstead
@agaudreault @kingbj940429
feat!: Logs rbac enforce by default (argoproj#21678)
4d117e9 
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Signed-off-by: Regina Voloshin <reginakagan@gmail.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Co-authored-by: rumstead <37445536+rumstead@users.noreply.github.com>
Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: kingbj0429 <kingbj0429@lunit.io>
@leoluz @kingbj940429
docs: add applicationset controller doc to preserve annotations and l…
7da9162 
…abels (argoproj#22008)

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Signed-off-by: kingbj0429 <kingbj0429@lunit.io>
@dependabot @kingbj940429
chore(deps): bump golang.org/x/oauth2 from 0.26.0 to 0.27.0 (argoproj…
d865076 
…#21990)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: kingbj0429 <kingbj0429@lunit.io>
@dependabot @kingbj940429
chore(deps): bump github.com/go-jose/go-jose/v4 from 4.0.2 to 4.0.5 (a…
50a0713 
…rgoproj#21989)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: kingbj0429 <kingbj0429@lunit.io>
@igaskin @kingbj940429
chore: version bumping helm3 (argoproj#22009)
233828b 
Signed-off-by: Isaac Gaskin <isaac.gaskin@circle.com>
Signed-off-by: kingbj0429 <kingbj0429@lunit.io>
@toyamagu-2021 @kingbj940429
fix: fetch syncedRevision in UpdateRevisionForPaths (argoproj#21014) (a…
ddd2751 
…rgoproj#21015)

Signed-off-by: toyamagu2021 <toyamagu2021@gmail.com>
Signed-off-by: toyamagu-2021 <toyamagu2021@gmail.com>
Signed-off-by: kingbj0429 <kingbj0429@lunit.io>
@nitishfy @blakepettersson @kingbj940429
docs: add more info on what login --core does (argoproj#21487)
b302d00 
Signed-off-by: nitishfy <justnitish06@gmail.com>
Signed-off-by: Nitish Kumar <justnitish06@gmail.com>
Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: kingbj0429 <kingbj0429@lunit.io>
@surajyadav1108 @kingbj940429
fix(ui): Added SSV option to helm type repos (argoproj#22006)
bb59553 
Signed-off-by: Surajyadav <harrypotter1108@gmail.com>
Signed-off-by: kingbj0429 <kingbj0429@lunit.io>
@kingbj940429 kingbj940429 force-pushed the kingbj940429/fix-history-causes-panic branch from 0a156f9 to bb59553 Compare February 26, 2025 17:10
@kingbj940429 kingbj940429 requested review from a team as code owners February 26, 2025 17:10
rumstead
rumstead reviewed Feb 26, 2025
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented Feb 26, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@b88ad57). Learn more about missing BASE report.
⚠️ Report is 788 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master   #22036   +/-   ##
=========================================
  Coverage          ?   53.96%           
=========================================
  Files             ?      342           
  Lines             ?    57091           
  Branches          ?        0           
=========================================
  Hits              ?    30812           
  Misses            ?    23692           
  Partials          ?     2587

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kingbj940429
chore: add test case when limit is negative
153f8e7 
Signed-off-by: kingbj0429 <kingbj0429@lunit.io>
@kingbj940429
chore: use assert empty
f3e5b30 
Signed-off-by: kingbj0429 <kingbj0429@lunit.io>
@kingbj940429
chore: add test case when limit is negative at trunc function
a9a9a87 
Signed-off-by: kingbj0429 <kingbj0429@lunit.io>
@kingbj940429
Copy link
Contributor Author

@rumstead
Can you review this PR again? :)

rumstead
rumstead approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@rumstead rumstead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the first contribution and bug fix! LGTM. Let's see if someone else with more familiarity can review as well.

@github-project-automation github-project-automation bot moved this to Ready for final review in Argo CD Review Mar 10, 2025
@agaudreault agaudreault merged commit 274e918 into argoproj:master May 8, 2025
32 checks passed
LyhengTep pushed a commit to LyhengTep/argo-cd that referenced this pull request May 10, 2025
@kingbj940429 @LyhengTep
fix(appcontroller): if a history limit is negative, automatically con…
5ba74d8 
…verted to 0 (argoproj#22036)

Signed-off-by: kingbj0429 <kingbj0429@lunit.io>
ranakan19 pushed a commit to ranakan19/argo-cd that referenced this pull request May 20, 2025
@kingbj940429 @ranakan19
fix(appcontroller): if a history limit is negative, automatically con…
7c4f98d 
…verted to 0 (argoproj#22036)

Signed-off-by: kingbj0429 <kingbj0429@lunit.io>
Signed-off-by: Kanika Rana <krana@redhat.com>
olivergondza pushed a commit to olivergondza/argo-cd that referenced this pull request May 20, 2025
@kingbj940429 @olivergondza
fix(appcontroller): if a history limit is negative, automatically con…
49936b1 
…verted to 0 (argoproj#22036)

Signed-off-by: kingbj0429 <kingbj0429@lunit.io>
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
tylerrosnett pushed a commit to StateFarmIns/argo-cd that referenced this pull request May 27, 2025
@kingbj940429 @tylerrosnett
fix(appcontroller): if a history limit is negative, automatically con…
dd1dcbb 
…verted to 0 (argoproj#22036)

Signed-off-by: kingbj0429 <kingbj0429@lunit.io>
chansuke pushed a commit to chansuke/argo-cd that referenced this pull request Jun 4, 2025
@kingbj940429 @chansuke
fix(appcontroller): if a history limit is negative, automatically con…
c12b44b 
…verted to 0 (argoproj#22036)

Signed-off-by: kingbj0429 <kingbj0429@lunit.io>
@nitishfy nitishfy mentioned this pull request Jun 18, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumstead rumstead rumstead approved these changes

@agaudreault agaudreault agaudreault approved these changes

+1 more reviewer

@andrii-korotkov-verkada andrii-korotkov-verkada andrii-korotkov-verkada approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ready-for-review
Projects
Argo CD Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@kingbj940429 @rumstead @agaudreault @andrii-korotkov-verkada @reggie-k @leoluz @igaskin @toyamagu-2021 @nitishfy @surajyadav1108