docs: add notifications examples section #22032
Conversation
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Signed-off-by: Aaron Hoffman <31711338+Aaron-9900@users.noreply.github.com>
178345b to
5b4e3bc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #22032 +/- ##
==========================================
+ Coverage 55.87% 55.91% +0.04%
==========================================
Files 343 343
Lines 57310 57310
==========================================
+ Hits 32022 32045 +23
+ Misses 22637 22627 -10
+ Partials 2651 2638 -13 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Aaron Hoffman <31711338+Aaron-9900@users.noreply.github.com>
Signed-off-by: Aaron Hoffman <31711338+Aaron-9900@users.noreply.github.com>
| "status": "Synced", | ||
| "syncPhase": "Sync", | ||
| "version": "v1" | ||
| images: [ |
There was a problem hiding this comment.
Would it be possible to add an example of a real-world usage of the images key? For example, could I have a notification that zips up all images across all resources, dedupes them, and sends that list as a Slack notification?
There was a problem hiding this comment.
dedupes them
That needs an external server I believe? Is the code for that something that should be in these docs?
|
|
||
| With this information you can, for example: | ||
| 1. Monitor the version of your image being deployed | ||
| 2. Be alerted in case of any vulnerability present in a new deployment |
There was a problem hiding this comment.
Can you go into more detail about how this would work?
There was a problem hiding this comment.
I think I'll remove this part about vulnerabilities. I was thinking of a use case like the following:
- Receive the webhook and images
- Compare those images against a vulnerability database
But I don't think this is a good use case in the end because there are tools specific for that, that scan your images before deploying, and it might be misleading to have this here
Added a different example
Signed-off-by: Aaron Hoffman <31711338+Aaron-9900@users.noreply.github.com>
0e12313 to
aff41f1
Compare
Signed-off-by: Aaron Hoffman <31711338+Aaron-9900@users.noreply.github.com>
Signed-off-by: Aaron Hoffman <31711338+Aaron-9900@users.noreply.github.com>
Signed-off-by: Aaron Hoffman <31711338+Aaron-9900@users.noreply.github.com>
|
@crenshaw-dev 👋🏼 I think I addressed the requested changes. Could you take another look? Thanks! |
Signed-off-by: Aaron Hoffman <31711338+Aaron-9900@users.noreply.github.com> Co-authored-by: Pasha Kostohrys <pasha.kostohrys@gmail.com> Signed-off-by: Hapshanko <adamgaming391100@gmail.com>
Docs for: #20896
Checklist: