Skip to content

fix(ui): Added SSV option to helm type repos #22006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 26, 2025
Merged

fix(ui): Added SSV option to helm type repos #22006

merged 3 commits into from
Feb 26, 2025

Conversation

surajyadav1108
Copy link
Contributor

@surajyadav1108 surajyadav1108 commented Feb 25, 2025 •
edited
Loading

Closes #21949

added-SSV.mp4

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@surajyadav1108
added-SSV-option-to-helm-type-repo
af7c610 
Signed-off-by: Surajyadav <harrypotter1108@gmail.com>
@surajyadav1108 surajyadav1108 requested a review from a team as a code owner February 25, 2025 15:33
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Feb 25, 2025 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

blakepettersson
blakepettersson approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@blakepettersson blakepettersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rumstead
rumstead approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@rumstead rumstead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@ishitasequeira ishitasequeira merged commit b88ad57 into argoproj:master Feb 26, 2025
29 checks passed
kingbj940429 pushed a commit to kingbj940429/argo-cd that referenced this pull request Feb 26, 2025
@surajyadav1108 @kingbj940429
fix(ui): Added SSV option to helm type repos (argoproj#22006)
bb59553 
Signed-off-by: Surajyadav <harrypotter1108@gmail.com>
Signed-off-by: kingbj0429 <kingbj0429@lunit.io>
harshitSkyscanner pushed a commit to harshitSkyscanner/argo-cd that referenced this pull request Feb 27, 2025
@surajyadav1108 @harshitSkyscanner
fix(ui): Added SSV option to helm type repos (argoproj#22006)
b9506bf 
Signed-off-by: Surajyadav <harrypotter1108@gmail.com>
Signed-off-by: Harshit-Bajpai <Harshit.Bajpai@skyscanner.net>
chzar pushed a commit to chzar/argo-cd that referenced this pull request Mar 3, 2025
@surajyadav1108 @chzar
fix(ui): Added SSV option to helm type repos (argoproj#22006)
9fce4fb 
Signed-off-by: Surajyadav <harrypotter1108@gmail.com>
kingbj940429 pushed a commit to kingbj940429/argo-cd that referenced this pull request Mar 4, 2025
@surajyadav1108 @kingbj940429
fix(ui): Added SSV option to helm type repos (argoproj#22006)
887653b 
Signed-off-by: Surajyadav <harrypotter1108@gmail.com>
Signed-off-by: kingbj0429 <kingbj0429@lunit.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakepettersson blakepettersson blakepettersson approved these changes

@rumstead rumstead rumstead approved these changes

@ishitasequeira ishitasequeira ishitasequeira approved these changes

+1 more reviewer

@andrii-korotkov-verkada andrii-korotkov-verkada andrii-korotkov-verkada approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ready-for-review
Projects
Argo CD Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

There is no option Skip server verification in Repository type helm
5 participants
@surajyadav1108 @blakepettersson @rumstead @ishitasequeira @andrii-korotkov-verkada