feat(health): add Rabbitmq topology resource customizations #22066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❗ Preview Environment undeploy from Bunnyshell failedSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Signed-off-by: Francis Provencher <fprovencher@drw.com>
Signed-off-by: Francis Provencher <fprovencher@drw.com>
Signed-off-by: Francis Provencher <fprovencher@drw.com>
Signed-off-by: Francis Provencher <fprovencher@drw.com>
Signed-off-by: Francis Provencher <fprovencher@drw.com>
Signed-off-by: Francis Provencher <fprovencher@drw.com>
8827d08 to
1c6ae59
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #22066 +/- ##
==========================================
+ Coverage 55.97% 55.99% +0.02%
==========================================
Files 343 343
Lines 57527 57527
==========================================
+ Hits 32202 32215 +13
+ Misses 22674 22664 -10
+ Partials 2651 2648 -3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Francis Provencher <fprovencher@drw.com>
Signed-off-by: Francis Provencher <fprovencher@drw.com>
| if condition.type ~= nil then | ||
| if condition.type == "Ready" then | ||
| if condition.status ~= nil and condition.reason ~= nil then | ||
| if condition.status == "True" and condition.reason == "SuccessfulCreateOrUpdate" then |
There was a problem hiding this comment.
Can you combine the nested ifs into one, e.g. condition.type ~= nil even seems unnecessary if we check for condition.type == "Ready"?
There was a problem hiding this comment.
Indeed, looking at the source code, if a condition is returned, it will have the type, status and reason keys, so no need to "nil check" them.
I removed the nil checks for the condition components.
| if condition.type ~= nil then | ||
| if condition.type == "Ready" then | ||
| if condition.status ~= nil and condition.reason ~= nil then | ||
| if condition.status == "True" and condition.reason == "SuccessfulCreateOrUpdate" then |
There was a problem hiding this comment.
| if condition.type ~= nil then | ||
| if condition.type == "Ready" then | ||
| if condition.status ~= nil and condition.reason ~= nil then | ||
| if condition.status == "True" and condition.reason == "SuccessfulCreateOrUpdate" then |
There was a problem hiding this comment.
| if condition.type ~= nil then | ||
| if condition.type == "Ready" then | ||
| if condition.status ~= nil and condition.reason ~= nil then | ||
| if condition.status == "True" and condition.reason == "SuccessfulCreateOrUpdate" then |
There was a problem hiding this comment.
| if condition.type ~= nil then | ||
| if condition.type == "Ready" then | ||
| if condition.status ~= nil and condition.reason ~= nil then | ||
| if condition.status == "True" and condition.reason == "SuccessfulCreateOrUpdate" then |
There was a problem hiding this comment.
| if condition.type ~= nil then | ||
| if condition.type == "Ready" then | ||
| if condition.status ~= nil and condition.reason ~= nil then | ||
| if condition.status == "True" and condition.reason == "SuccessfulCreateOrUpdate" then |
There was a problem hiding this comment.
Signed-off-by: Francis Provencher <fprovencher@drw.com>
Signed-off-by: Francis Provencher <fprovencher@drw.com>
Signed-off-by: Francis Provencher <fprovencher@drw.com>
|
Hi, We are very interested, in my company, to have those new health checks, when do you think it will be available ? Thinks |
LyhengTep
pushed a commit
to LyhengTep/argo-cd
that referenced
this pull request
May 24, 2025
…#22066) Signed-off-by: Francis Provencher <fprovencher@drw.com> Signed-off-by: Lyheng <lyhengtep@gmail.com>
tylerrosnett
pushed a commit
to StateFarmIns/argo-cd
that referenced
this pull request
May 27, 2025
…#22066) Signed-off-by: Francis Provencher <fprovencher@drw.com>
chansuke
pushed a commit
to chansuke/argo-cd
that referenced
this pull request
Jun 4, 2025
…#22066) Signed-off-by: Francis Provencher <fprovencher@drw.com>
dsuhinin
pushed a commit
to dsuhinin/argo-cd
that referenced
this pull request
Jun 16, 2025
…#22066) Signed-off-by: Francis Provencher <fprovencher@drw.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
dsuhinin
pushed a commit
to dsuhinin/argo-cd
that referenced
this pull request
Jun 16, 2025
…#22066) Signed-off-by: Francis Provencher <fprovencher@drw.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kept it simple.
There are only 2 defined states (on top of unknown) as per: https://github.com/rabbitmq/messaging-topology-operator/blob/0c910d977b21b4610b789a90e7edfc8ca42d9649/api/v1beta1/conditions.go#L26
Checklist: