Skip to content

feat: Logs rbac enforce by default #21678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 25, 2025
Merged

feat: Logs rbac enforce by default #21678

merged 8 commits into from
Feb 25, 2025

Conversation

reggie-k
Copy link
Member

Closes #10551

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@reggie-k
gotestsum locally from dist, containerized from /usr/local/bin
7101684 
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
@reggie-k
remove functionality and tests
6737b9a 
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
@reggie-k
Merge branch 'master' of https://github.com/argoproj/argo-cd into log…
2e28b80 
…s-rbac-enforce-by-default
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Jan 27, 2025 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@reggie-k
docs update
2aee7a0 
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
@reggie-k
fix the project scope allow test
d29a837 
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
@codecov Codecov
Copy link

codecov bot commented Jan 27, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 55.75%. Comparing base (e784c47) to head (79f130b).
Report is 440 commits behind head on master.

Files with missing lines Patch % Lines
cmd/argocd/commands/admin/settings_rbac.go 40.00% 3 Missing ⚠️
server/application/application.go 0.00% 1 Missing and 1 partial ⚠️
cmd/argocd/commands/admin/settings.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #21678      +/-   ##
==========================================
+ Coverage   55.72%   55.75%   +0.03%     
==========================================
  Files         342      342              
  Lines       57082    57040      -42     
==========================================
- Hits        31808    31803       -5     
+ Misses      22632    22608      -24     
+ Partials     2642     2629      -13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reggie-k
docs
67abba5 
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
@reggie-k reggie-k marked this pull request as ready for review February 3, 2025 12:35
@reggie-k reggie-k requested review from a team as code owners February 3, 2025 12:35
@reggie-k reggie-k mentioned this pull request Feb 3, 2025
Closed
7 tasks
rumstead
rumstead reviewed Feb 5, 2025
View reviewed changes
@reggie-k @rumstead
Update docs/operator-manual/upgrading/2.14-3.0.md
fff72cf 
Co-authored-by: rumstead <37445536+rumstead@users.noreply.github.com>
Signed-off-by: Regina Voloshin <reginakagan@gmail.com>
agaudreault
agaudreault approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@agaudreault agaudreault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agaudreault agaudreault self-assigned this Feb 25, 2025
@agaudreault
Merge branch 'master' into logs-rbac-enforce-by-default
79f130b 
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
@agaudreault agaudreault enabled auto-merge (squash) February 25, 2025 17:20
@agaudreault agaudreault merged commit 402802b into argoproj:master Feb 25, 2025
26 checks passed
kingbj940429 pushed a commit to kingbj940429/argo-cd that referenced this pull request Feb 26, 2025
@reggie-k @rumstead
@agaudreault @kingbj940429
feat!: Logs rbac enforce by default (argoproj#21678)
4d117e9 
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Signed-off-by: Regina Voloshin <reginakagan@gmail.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Co-authored-by: rumstead <37445536+rumstead@users.noreply.github.com>
Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: kingbj0429 <kingbj0429@lunit.io>
chzar pushed a commit to chzar/argo-cd that referenced this pull request Mar 3, 2025
@reggie-k @rumstead
@agaudreault @chzar
feat!: Logs rbac enforce by default (argoproj#21678)
796a346 
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Signed-off-by: Regina Voloshin <reginakagan@gmail.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Co-authored-by: rumstead <37445536+rumstead@users.noreply.github.com>
Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
kingbj940429 pushed a commit to kingbj940429/argo-cd that referenced this pull request Mar 4, 2025
@reggie-k @rumstead
@agaudreault @kingbj940429
feat!: Logs rbac enforce by default (argoproj#21678)
9de85e7 
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
Signed-off-by: Regina Voloshin <reginakagan@gmail.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Co-authored-by: rumstead <37445536+rumstead@users.noreply.github.com>
Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: kingbj0429 <kingbj0429@lunit.io>
reggie-k added a commit to reggie-k/argo-cd that referenced this pull request Mar 10, 2025
@reggie-k
Revert "feat!: Logs rbac enforce by default (argoproj#21678)"
33c1818 
This reverts commit 402802b.
reggie-k added a commit to reggie-k/argo-cd that referenced this pull request Mar 10, 2025
@reggie-k
Revert "feat!: Logs rbac enforce by default (argoproj#21678)"
1877b86 
This reverts commit 402802b.

Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
@aali309 aali309 mentioned this pull request Jun 3, 2025
Merged
2 tasks
@reggie-k reggie-k deleted the logs-rbac-enforce-by-default branch June 15, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumstead rumstead rumstead left review comments

@agaudreault agaudreault agaudreault approved these changes

Assignees

@agaudreault agaudreault

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable logs RBAC enforcement by default
3 participants
@reggie-k @rumstead @agaudreault