Skip to content

feat(ui): disable select not running pod and bring back arrow to selected pod #21576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 8, 2025
Merged

feat(ui): disable select not running pod and bring back arrow to selected pod #21576

merged 2 commits into from
May 8, 2025

Conversation

linghaoSu
Copy link
Member

@linghaoSu linghaoSu commented Jan 20, 2025 •
edited
Loading

Summary

Fixes #21621

  1. Disabled the ability to select pods that are not running.
  2. Fixed the issue where the arrow indicating the selected pod loses its style.

Before

image

After

image
image

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Jan 20, 2025 •
edited
Loading

❗ Preview Environment undeploy from Bunnyshell failed

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🚀 /bns:deploy to redeploy the environment
  • ❌ /bns:delete to try again to remove the environment

@linghaoSu linghaoSu force-pushed the feat/add-disabled-tip-for-terminated-pod branch from 45c0e1b to 1f566ef Compare January 20, 2025 10:53
@linghaoSu linghaoSu marked this pull request as ready for review January 20, 2025 10:53
@linghaoSu linghaoSu requested a review from a team as a code owner January 20, 2025 10:53
@linghaoSu
feat(ui): disable select not running pod and bring back arrow point t…
1a29574 
…o selected pod

Signed-off-by: linghaoSu <linghao.su@daocloud.io>
@linghaoSu linghaoSu force-pushed the feat/add-disabled-tip-for-terminated-pod branch from 1f566ef to 1a29574 Compare January 20, 2025 10:54
@linghaoSu
fix(ui): add missing inverted prop in TooltipWrapper
2081ea7 
Signed-off-by: linghaoSu <linghao.su@daocloud.io>
@linghaoSu linghaoSu force-pushed the feat/add-disabled-tip-for-terminated-pod branch from f830847 to 2081ea7 Compare February 7, 2025 07:32
@agaudreault agaudreault merged commit 30742f6 into argoproj:master May 8, 2025
28 checks passed
@github-project-automation github-project-automation bot moved this from Ready for final review to Done in Argo CD Review May 8, 2025
@linghaoSu linghaoSu deleted the feat/add-disabled-tip-for-terminated-pod branch May 9, 2025 01:55
LyhengTep pushed a commit to LyhengTep/argo-cd that referenced this pull request May 10, 2025
@linghaoSu @LyhengTep
feat(ui): disable select not running pod and bring back arrow to sele…
65040f4 
…cted pod (argoproj#21576)

Signed-off-by: linghaoSu <linghao.su@daocloud.io>
ranakan19 pushed a commit to ranakan19/argo-cd that referenced this pull request May 20, 2025
@linghaoSu @ranakan19
feat(ui): disable select not running pod and bring back arrow to sele…
2e0e5e4 
…cted pod (argoproj#21576)

Signed-off-by: linghaoSu <linghao.su@daocloud.io>
Signed-off-by: Kanika Rana <krana@redhat.com>
olivergondza pushed a commit to olivergondza/argo-cd that referenced this pull request May 20, 2025
@linghaoSu @olivergondza
feat(ui): disable select not running pod and bring back arrow to sele…
f90e864 
…cted pod (argoproj#21576)

Signed-off-by: linghaoSu <linghao.su@daocloud.io>
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
tylerrosnett pushed a commit to StateFarmIns/argo-cd that referenced this pull request May 27, 2025
@linghaoSu @tylerrosnett
feat(ui): disable select not running pod and bring back arrow to sele…
a106b41 
…cted pod (argoproj#21576)

Signed-off-by: linghaoSu <linghao.su@daocloud.io>
chansuke pushed a commit to chansuke/argo-cd that referenced this pull request Jun 4, 2025
@linghaoSu @chansuke
feat(ui): disable select not running pod and bring back arrow to sele…
14bc81d 
…cted pod (argoproj#21576)

Signed-off-by: linghaoSu <linghao.su@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agaudreault agaudreault agaudreault approved these changes

+1 more reviewer

@andrii-korotkov-verkada andrii-korotkov-verkada andrii-korotkov-verkada approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ready-for-review
Projects
Argo CD Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Visually Differentiate Non-Terminal Accessible Containers
3 participants
@linghaoSu @agaudreault @andrii-korotkov-verkada