feat: Add link to get the list of applications of a cluster/project #21561
Conversation
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
2f911b5 to
e35b614
Compare
…r summary page and applications link in project summary page Signed-off-by: Almo Elda <almogldbh@gmail.com>
Signed-off-by: Almo Elda <almogldbh@gmail.com>
968b057 to
6e801c5
Compare
Sure. @reggie-k |
| apps.items.filter(app => app.spec.destination.name === cluster.name || app.spec.destination.server === cluster.server) | ||
| .length |
There was a problem hiding this comment.
Thanks for the PR! It looks great in the UI!
Why do we have to filter the results here?
There was a problem hiding this comment.
Please correct me if I am wrong, I believe that the query options does not provide any way to filter by cluster, by taking a look at this https://github.com/argoproj/argo-cd/blob/master/pkg/apiclient/application/application.pb.go#L44-L64 I learned from this file which is filtering apps with the filter function as well https://github.com/argoproj/argo-cd/blob/master/ui/src/app/applications/components/application-details/application-details-app-dropdown.tsx#L38-L43
There was a problem hiding this comment.
I see, I wonder whether we can filter inside list in ApplicationService instead?
There was a problem hiding this comment.
Do you mean altering the QueryOptions or adding another callback to filter?
There was a problem hiding this comment.
hey @reggie-k
How you suggest we proceed here?
Thanks :)
There was a problem hiding this comment.
It is an option to introduce a new field to ApplicationQuery, and then have it filtered on the backend side.
Actually, the CLI today does have an option to filter by cluster for argocd app list.
But I wanna hear more maintainers' opinions on whether we should do this API change or just have the filtering frontend-side.
…ications-link-in-settings Signed-off-by: Almo Elda <almogldbh@gmail.com>
|
@nitishfy , @agaudreault did you want either option 1 or option 2, or both? Here's my two cents worth: For option 1, I suggest to have the "list of applications" (eg. in a table format, and to clarify, not the view itself). Possibly, for each application row, there is a link that brings you to the Application's details graphical view. That way, we don't have to add filters. You could add additional features to this new panel by also including a link (not part of the table that I described above) to the Application List view (graphical) and have the filter enabled for project or cluster. (Just like this PR here) For option 2, I think it is the simplest solution and likely still resolves the same usability concerns. It will use the existing graphical view to give you the same information that you want, just like in this new tab. So, I'd pick option 2 for its simplicity. |
…rgoproj#21561) Signed-off-by: Almo Elda <almogldbh@gmail.com>
…rgoproj#21561) Signed-off-by: Almo Elda <almogldbh@gmail.com> Signed-off-by: Hapshanko <adamgaming391100@gmail.com>
Closes #21454
Checklist: