feat(health): add kyverno Policy resource customization #21552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❗ Preview Environment undeploy from Bunnyshell failedSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
marckhair
commented
Jan 17, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21552 +/- ##
=======================================
Coverage 55.97% 55.98%
=======================================
Files 343 343
Lines 57527 57527
=======================================
+ Hits 32202 32206 +4
+ Misses 22674 22669 -5
- Partials 2651 2652 +1 ☔ View full report in Codecov by Sentry. |
marckhair
commented
Jan 22, 2025
resource_customizations/kyverno.io/Policy/testdata/healthy.yaml
Outdated
Show resolved
Hide resolved
marckhair
commented
Jan 22, 2025
a6756ce to
2917775
Compare
Signed-off-by: Marc Khair <67377306+marckhair@users.noreply.github.com>
7c4701f to
4919c8c
Compare
|
Can anyone review please? @blakepettersson @crenshaw-dev |
marckhair
commented
Jan 22, 2025
marckhair
commented
Jan 22, 2025
marckhair
commented
Jan 22, 2025
todaywasawesome
approved these changes
Jan 23, 2025
|
@crenshaw-dev can anyone take a look at this please? |
andrii-korotkov-verkada
approved these changes
Feb 7, 2025
|
|
||
| hs.status = "Progressing" | ||
| hs.message = "Waiting for Policy to be ready" | ||
| return hs |
There was a problem hiding this comment.
Can it ever be unhealthy?
There was a problem hiding this comment.
Based on the status conditions I see, I don't think so. I might be wrong, my experience with the Policy objects lifecycle is limited.
agaudreault
approved these changes
May 7, 2025
LyhengTep
pushed a commit
to LyhengTep/argo-cd
that referenced
this pull request
May 10, 2025
Signed-off-by: Marc Khair <67377306+marckhair@users.noreply.github.com>
ranakan19
pushed a commit
to ranakan19/argo-cd
that referenced
this pull request
May 20, 2025
Signed-off-by: Marc Khair <67377306+marckhair@users.noreply.github.com> Signed-off-by: Kanika Rana <krana@redhat.com>
olivergondza
pushed a commit
to olivergondza/argo-cd
that referenced
this pull request
May 20, 2025
Signed-off-by: Marc Khair <67377306+marckhair@users.noreply.github.com> Signed-off-by: Oliver Gondža <ogondza@gmail.com>
tylerrosnett
pushed a commit
to StateFarmIns/argo-cd
that referenced
this pull request
May 27, 2025
Signed-off-by: Marc Khair <67377306+marckhair@users.noreply.github.com>
chansuke
pushed a commit
to chansuke/argo-cd
that referenced
this pull request
Jun 4, 2025
Signed-off-by: Marc Khair <67377306+marckhair@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding custom health check logic for
kyverno.io/Policyobjects.