Skip to content

chore: use %q to simplify fmt.Sprintf #21108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2024
Merged

chore: use %q to simplify fmt.Sprintf #21108

merged 1 commit into from
Dec 9, 2024

Conversation

marinesnow34
Copy link
Contributor

Simplifies strings inside fmt.Sprintf statements. Replace \"%s\" with %q.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@marinesnow34
chore: use %q to simplify fmt.Sprintf
a5d5b34 
Signed-off-by: Joowon Lim <m4rinesnow34@gmail.com>
@marinesnow34 marinesnow34 requested a review from a team as a code owner December 9, 2024 17:11
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Dec 9, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@crenshaw-dev crenshaw-dev merged commit 35c12d9 into argoproj:master Dec 9, 2024
49 checks passed
@crenshaw-dev
Copy link
Member

Thanks @marinesnow34!

dudo pushed a commit to dudo/argo-cd that referenced this pull request Jan 18, 2025
@marinesnow34 @dudo
chore: use %q to simplify fmt.Sprintf (argoproj#21108)
352bcf3 
Signed-off-by: Joowon Lim <m4rinesnow34@gmail.com>
Signed-off-by: Brett C. Dudo <brett@dudo.io>
revitalbarletz pushed a commit to revitalbarletz/argo-cd that referenced this pull request Jan 20, 2025
@marinesnow34 @revitalbarletz
chore: use %q to simplify fmt.Sprintf (argoproj#21108)
e5cf894 
Signed-off-by: Joowon Lim <m4rinesnow34@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marinesnow34 @crenshaw-dev