-
Notifications
You must be signed in to change notification settings - Fork 6.4k
chore(appset): reduce dupe code w/ DB #21192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(appset): reduce dupe code w/ DB #21192
Conversation
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #21192 +/- ##
=========================================
Coverage ? 55.21%
=========================================
Files ? 324
Lines ? 55625
Branches ? 0
=========================================
Hits ? 30714
Misses ? 22285
Partials ? 2626 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense!! LGTM!!
* chore(appset): reduce dupe code w/ DB Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * fix imports Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Brett C. Dudo <brett@dudo.io>
* chore(appset): reduce dupe code w/ DB Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * fix imports Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* chore(appset): reduce dupe code w/ DB Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * fix imports Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
The clusterUtils function is almost identical to the DB function. Green in the diff below is the DB function.
Since the DB function populates Labels and Annotations, I'm dropping those just to be safe. I'm leaving the logic that populates the Project and ClusterResources fields, because I can't think of a reason why populating those could be problematic.