chore(server): simplify project validation logic #21191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21191 +/- ##
=========================================
Coverage ? 55.24%
=========================================
Files ? 324
Lines ? 55650
Branches ? 0
=========================================
Hits ? 30743
Misses ? 22281
Partials ? 2626 ☔ View full report in Codecov by Sentry. |
dudo
pushed a commit
to dudo/argo-cd
that referenced
this pull request
Jan 18, 2025
* chore(server): simplify project validation logic Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * improve tests Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Brett C. Dudo <brett@dudo.io>
revitalbarletz
pushed a commit
to revitalbarletz/argo-cd
that referenced
this pull request
Jan 20, 2025
* chore(server): simplify project validation logic Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * improve tests Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
vasilegroza
pushed a commit
to vasilegroza/argo-cd
that referenced
this pull request
Feb 27, 2025
* chore(server): simplify project validation logic Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * improve tests Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, there's no reason to temporarily store these apps in new slices. We already have all the information we need to perform the validation.