Skip to content

fix(cli): Fix appset generate in --core mode for cluster gen #21170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2024
Merged

fix(cli): Fix appset generate in --core mode for cluster gen #21170

merged 1 commit into from
Dec 16, 2024

Conversation

OpenGuidou
Copy link
Contributor

@OpenGuidou OpenGuidou commented Dec 13, 2024 •
edited
Loading

Complement of #20717 for the use case with cluster generators, producing the error:

error getting cluster secrets: no kind is registered for the type v1.SecretList in scheme

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@OpenGuidou OpenGuidou requested a review from a team as a code owner December 13, 2024 15:38
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Dec 13, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@OpenGuidou
fix(appset): Fix appset generate in --core mode for cluster gen
a17f086 
Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>
@OpenGuidou OpenGuidou changed the title fix(appset): Fix appset generate in --core mode for cluster gen fix(cli): Fix appset generate in --core mode for cluster gen Dec 13, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 55.19%. Comparing base (be080a5) to head (a17f086).
Report is 438 commits behind head on master.

Files with missing lines Patch % Lines
cmd/argocd/commands/headless/headless.go 0.00% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #21170      +/-   ##
==========================================
+ Coverage   53.79%   55.19%   +1.39%     
==========================================
  Files         324      324              
  Lines       55603    55607       +4     
==========================================
+ Hits        29914    30690     +776     
+ Misses      23087    22289     -798     
- Partials     2602     2628      +26

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OpenGuidou
Copy link
Contributor Author

@andrii-korotkov-verkada @ishitasequeira would you mind checking this one as well ?

ishitasequeira
ishitasequeira approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@ishitasequeira ishitasequeira merged commit bce16e9 into argoproj:master Dec 16, 2024
33 checks passed
@OpenGuidou
Copy link
Contributor Author

/cherry-pick release-2.13

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Dec 18, 2024
@OpenGuidou
fix(appset): Fix appset generate in --core mode for cluster gen (#21170)
e2f9c30 
Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Dec 18, 2024
Merged
ishitasequeira pushed a commit that referenced this pull request Dec 18, 2024
@gcp-cherry-pick-bot @OpenGuidou
fix(appset): Fix appset generate in --core mode for cluster gen (#21170…
09eede0 
…) (#21236)

Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>
Co-authored-by: OpenGuidou <73480729+OpenGuidou@users.noreply.github.com>
dudo pushed a commit to dudo/argo-cd that referenced this pull request Jan 18, 2025
@OpenGuidou @dudo
fix(appset): Fix appset generate in --core mode for cluster gen (argo…
9d06eab 
…proj#21170)

Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>
Signed-off-by: Brett C. Dudo <brett@dudo.io>
revitalbarletz pushed a commit to revitalbarletz/argo-cd that referenced this pull request Jan 20, 2025
@OpenGuidou @revitalbarletz
fix(appset): Fix appset generate in --core mode for cluster gen (argo…
38d1061 
…proj#21170)

Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>
vasilegroza pushed a commit to vasilegroza/argo-cd that referenced this pull request Feb 27, 2025
@OpenGuidou @vasilegroza
fix(appset): Fix appset generate in --core mode for cluster gen (argo…
85fba8a 
…proj#21170)

Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishitasequeira ishitasequeira ishitasequeira approved these changes

+1 more reviewer

@andrii-korotkov-verkada andrii-korotkov-verkada andrii-korotkov-verkada approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ready-for-review
Projects
Argo CD Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OpenGuidou @ishitasequeira @andrii-korotkov-verkada