Skip to content

docs: update sync-wave documentation #21155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2024
Merged

docs: update sync-wave documentation #21155

merged 1 commit into from
Dec 16, 2024

Conversation

chansuke
Copy link
Contributor

Closes #21125

Added the description of sync-wave duplication.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@chansuke
docs: update sync-wave documentation
e27d62e 
Signed-off-by: chansuke <moonset20@gmail.com>
@chansuke chansuke requested review from a team as code owners December 12, 2024 14:14
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Dec 12, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@andrii-korotkov-verkada andrii-korotkov-verkada added the ready-for-review An approver should give a final review and merge the PR label Dec 14, 2024
ishitasequeira
ishitasequeira approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Thanks @chansuke !!

@ishitasequeira ishitasequeira merged commit 4d17bf3 into argoproj:master Dec 16, 2024
28 checks passed
dudo pushed a commit to dudo/argo-cd that referenced this pull request Jan 18, 2025
@chansuke @dudo
docs: update sync-wave documentation (argoproj#21155)
b264dc3 
Signed-off-by: chansuke <moonset20@gmail.com>
Signed-off-by: Brett C. Dudo <brett@dudo.io>
revitalbarletz pushed a commit to revitalbarletz/argo-cd that referenced this pull request Jan 20, 2025
@chansuke @revitalbarletz
docs: update sync-wave documentation (argoproj#21155)
42f1a07 
Signed-off-by: chansuke <moonset20@gmail.com>
vasilegroza pushed a commit to vasilegroza/argo-cd that referenced this pull request Feb 27, 2025
@chansuke @vasilegroza
docs: update sync-wave documentation (argoproj#21155)
f89320a 
Signed-off-by: chansuke <moonset20@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishitasequeira ishitasequeira ishitasequeira approved these changes

+1 more reviewer

@andrii-korotkov-verkada andrii-korotkov-verkada andrii-korotkov-verkada approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ready-for-review An approver should give a final review and merge the PR
Projects
Argo CD Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOCS] Clarify in documentation whether sync-wave values can be duplicated
3 participants
@chansuke @ishitasequeira @andrii-korotkov-verkada