Skip to content

feat: support gitea PR labels filter in applicationset PR generator (#21115) #21148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
May 8, 2025
Merged

feat: support gitea PR labels filter in applicationset PR generator (#21115) #21148

merged 13 commits into from
May 8, 2025

Conversation

livelxw
Copy link
Contributor

@livelxw livelxw commented Dec 12, 2024

Fixes #21115

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@livelxw livelxw requested a review from a team as a code owner December 12, 2024 06:00
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Dec 12, 2024 •
edited
Loading

❗ Preview Environment undeploy from Bunnyshell failed

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🚀 /bns:deploy to redeploy the environment
  • ❌ /bns:delete to try again to remove the environment

@codecov Codecov
Copy link

codecov bot commented Dec 12, 2024 •
edited
Loading

Codecov Report

❌ Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.01%. Comparing base (bd30eea) to head (7bf8104).
⚠️ Report is 464 commits behind head on master.

Files with missing lines Patch % Lines
applicationset/services/pull_request/gitea.go 86.66% 1 Missing and 1 partial ⚠️
applicationset/generators/pull_request.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #21148      +/-   ##
==========================================
+ Coverage   59.97%   60.01%   +0.04%     
==========================================
  Files         344      344              
  Lines       57765    57778      +13     
==========================================
+ Hits        34644    34677      +33     
+ Misses      20357    20340      -17     
+ Partials     2764     2761       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@livelxw
feat: add labels filter to gitea in PR generator
d65d300 
Signed-off-by: livelxw <livelxw@live.cn>
@livelxw livelxw force-pushed the feature/support-gitea-pr-labels-filter branch from fbc0f3e to d65d300 Compare December 13, 2024 03:51
@livelxw
fix: use map to check labels in gitea
7e26885 
Signed-off-by: livelxw <livelxw@live.cn>
@livelxw
fix: lint
ebed776 
Signed-off-by: livelxw <livelxw@live.cn>
@livelxw
Merge branch 'master' into feature/support-gitea-pr-labels-filter
a5ec3ff
@livelxw
Copy link
Contributor Author

livelxw commented Dec 16, 2024 

==================
    testing.go:1399: race detected during execution of test

=== FAIL: server/application TestMaxPodLogsRender (3.42s)

There is an error in unit tests. How to fix that?

@livelxw
Merge branch 'master' into feature/support-gitea-pr-labels-filter
b1914b6 
Signed-off-by: livelxw <livelxw@live.cn>
@livelxw
fix: codegen
447355e 
Signed-off-by: livelxw <livelxw@live.cn>
andrii-korotkov-verkada
andrii-korotkov-verkada approved these changes Jan 1, 2025
View reviewed changes
applicationset/services/pull_request/gitea.go Outdated
// containLabels returns true if gotLabels contains expectedLabels
func giteaContainLabels(expectedLabels []string, gotLabels []*gitea.Label) bool {
gotLabelNamesMap := make(map[string]bool)
for i := 0; i < len(gotLabels); i += 1 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do i++

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@livelxw
Merge branch 'master' into feature/support-gitea-pr-labels-filter
2e1275d 
Signed-off-by: livelxw <livelxw@live.cn>
@livelxw
fix: generated code
4e73a5e 
Signed-off-by: livelxw <livelxw@live.cn>
@livelxw
fix: generated code
3f88823 
Signed-off-by: livelxw <livelxw@live.cn>
@apakhomov
Copy link

Hi! Sorry for my impatience. Any updates on this? I'm looking forward to this PR to be used with Forgejo flows

agaudreault added 2 commits May 8, 2025 15:09
@agaudreault
Merge remote-tracking branch 'upstream/master' into feature/support-g…
baf3797 
…itea-pr-labels-filter

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
@agaudreault
codegen
7bf8104 
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
agaudreault
agaudreault approved these changes May 8, 2025
View reviewed changes
Copy link
Member

@agaudreault agaudreault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agaudreault agaudreault enabled auto-merge (squash) May 8, 2025 22:19
@agaudreault agaudreault merged commit d284b15 into argoproj:master May 8, 2025
26 checks passed
@github-project-automation github-project-automation bot moved this from Ready for final review to Done in Argo CD Review May 8, 2025
LyhengTep pushed a commit to LyhengTep/argo-cd that referenced this pull request May 10, 2025
@livelxw @agaudreault @LyhengTep
feat: support gitea PR labels filter in appset PR generator (argoproj…
fc797af 
…#21115) (argoproj#21148)

Signed-off-by: livelxw <livelxw@live.cn>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
ranakan19 pushed a commit to ranakan19/argo-cd that referenced this pull request May 20, 2025
@livelxw @agaudreault @ranakan19
feat: support gitea PR labels filter in appset PR generator (argoproj…
64bfe34 
…#21115) (argoproj#21148)

Signed-off-by: livelxw <livelxw@live.cn>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Kanika Rana <krana@redhat.com>
olivergondza pushed a commit to olivergondza/argo-cd that referenced this pull request May 20, 2025
@livelxw @agaudreault @olivergondza
feat: support gitea PR labels filter in appset PR generator (argoproj…
4621c0a 
…#21115) (argoproj#21148)

Signed-off-by: livelxw <livelxw@live.cn>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
@livelxw livelxw deleted the feature/support-gitea-pr-labels-filter branch May 21, 2025 13:52
tylerrosnett pushed a commit to StateFarmIns/argo-cd that referenced this pull request May 27, 2025
@livelxw @agaudreault @tylerrosnett
feat: support gitea PR labels filter in appset PR generator (argoproj…
517fdad 
…#21115) (argoproj#21148)

Signed-off-by: livelxw <livelxw@live.cn>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
chansuke pushed a commit to chansuke/argo-cd that referenced this pull request Jun 4, 2025
@livelxw @agaudreault @chansuke
feat: support gitea PR labels filter in appset PR generator (argoproj…
7ea4a4f 
…#21115) (argoproj#21148)

Signed-off-by: livelxw <livelxw@live.cn>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agaudreault agaudreault agaudreault approved these changes

+2 more reviewers

@bashlion bashlion bashlion approved these changes

@andrii-korotkov-verkada andrii-korotkov-verkada andrii-korotkov-verkada approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ready-for-review
Projects
Argo CD Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support labels filter in gitea PR generator applicationset
5 participants
@livelxw @apakhomov @agaudreault @bashlion @andrii-korotkov-verkada