Skip to content

chore: fixes tests failing with kustomize based errors when Argo CD is built locally (#21036) #21037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2024
Merged

chore: fixes tests failing with kustomize based errors when Argo CD is built locally (#21036) #21037

merged 1 commit into from
Dec 3, 2024

Conversation

dudinea
Copy link
Member

@dudinea dudinea commented Dec 3, 2024 •
edited
Loading

Fixes #21036

This patch updates the Kustomize versions that installed by
./hack/installers/install-codegen-tools.sh so new version of kustomize does not
get overwritten by the obsolete one that broke the tests. The manifests
that new version generates are the same that were generated by the old version, so,
I suppose, there is no need to keep old version for code generation.

It as well adds support for the BIN environment variable in the
hack/installers/install-kustomize.sh, so its behaviour now matches
the documentation and kustomize is installed
in user specified directory on

BIN=~/go/bin make install-tools-local

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@dudinea
chore: fix tests failing with Kustomize based errors
5a1b5bc 
Signed-off-by: Eugene Doudine <eugene.d@trekflow.com>
@dudinea dudinea requested a review from a team as a code owner December 3, 2024 06:50
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Dec 3, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@codecov Codecov
Copy link

codecov bot commented Dec 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.04%. Comparing base (bd5d76f) to head (5a1b5bc).
Report is 398 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #21037      +/-   ##
==========================================
+ Coverage   55.02%   55.04%   +0.02%     
==========================================
  Files         324      324              
  Lines       55472    55482      +10     
==========================================
+ Hits        30522    30542      +20     
+ Misses      22329    22320       -9     
+ Partials     2621     2620       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

reggie-k
reggie-k approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@reggie-k reggie-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, reproduced the issue + verified the fix resolves it.

@pasha-codefresh pasha-codefresh merged commit 0d7f1f7 into argoproj:master Dec 3, 2024
28 checks passed
adriananeci pushed a commit to adriananeci/argo-cd that referenced this pull request Dec 4, 2024
@dudinea @adriananeci
chore: fix tests failing with Kustomize based errors (argoproj#21037)
f0b8bee 
Signed-off-by: Eugene Doudine <eugene.d@trekflow.com>
Signed-off-by: Adrian Aneci <aneci@adobe.com>
revitalbarletz pushed a commit to revitalbarletz/argo-cd that referenced this pull request Jan 20, 2025
@dudinea @revitalbarletz
chore: fix tests failing with Kustomize based errors (argoproj#21037)
7ce8b9b 
Signed-off-by: Eugene Doudine <eugene.d@trekflow.com>
@dudinea dudinea mentioned this pull request Aug 3, 2025
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reggie-k reggie-k reggie-k approved these changes

@pasha-codefresh pasha-codefresh pasha-codefresh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests fail with Kustomize related errors when Argo CD is built according to the Developer Guide
3 participants
@dudinea @reggie-k @pasha-codefresh