Skip to content

Conversation

agoddard
Copy link
Contributor

@agoddard agoddard commented Dec 1, 2024

minor update to wording around the use of ref when using multiple repos for helm values. Given the ambiguity of the term ref in the context of git repos generally, the additional clarity should help new users.

Signed-off-by: Anthony Goddard <anthony@anthonygoddard.com>
@agoddard agoddard requested review from a team as code owners December 1, 2024 01:59
Copy link

bunnyshell bot commented Dec 1, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@agoddard agoddard changed the title clarify usage of ref for multiple sources doc docs: clarify usage of ref parameter and $values variable with Helm multiple sources Dec 1, 2024
@andrii-korotkov-verkada andrii-korotkov-verkada added the ready-for-review An approver should give a final review and merge the PR label Dec 1, 2024
Copy link
Member

@blakepettersson blakepettersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@blakepettersson blakepettersson merged commit f4d1e0f into argoproj:master Dec 2, 2024
28 of 29 checks passed
adriananeci pushed a commit to adriananeci/argo-cd that referenced this pull request Dec 4, 2024
Signed-off-by: Anthony Goddard <anthony@anthonygoddard.com>
Signed-off-by: Adrian Aneci <aneci@adobe.com>
revitalbarletz pushed a commit to revitalbarletz/argo-cd that referenced this pull request Jan 20, 2025
Signed-off-by: Anthony Goddard <anthony@anthonygoddard.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review An approver should give a final review and merge the PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants