Skip to content

chore: Improve the documentation regarding the selection of Application on by Sync Windows (#20971) #21093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2024
Merged

chore: Improve the documentation regarding the selection of Application on by Sync Windows (#20971) #21093

merged 1 commit into from
Dec 11, 2024

Conversation

thecooldrop
Copy link
Contributor

Added documentation requested by issue #20971

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates? Yes
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@thecooldrop
chore: Improve the documentation regarding the selection of Applicati…
d9f140a 
…on by Sync Windows

Signed-off-by: TheCoolDrop <vanio.begic123@gmail.com>
@thecooldrop thecooldrop requested review from a team as code owners December 8, 2024 14:44
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Dec 8, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@andrii-korotkov-verkada andrii-korotkov-verkada added the ready-for-review An approver should give a final review and merge the PR label Dec 9, 2024
adriananeci
adriananeci reviewed Dec 9, 2024
View reviewed changes
docs/user-guide/sync_windows.md
All three mechanisms allow usage of wildcards. The mechanisms are not mutually exclusive, and all three of them can be used in single
Sync Window definition.

When multiple selection mechanisms are used, they are effectively `ORed`, meaning that if any of the selector selects the Application,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've raised a while ago a PR for adding also AND support. #16846 is still open, not sure if you want to mentioned it here or I can update the docs once that PR is close to being merged.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @adriananeci, I think that proper way forward here is to have your branch rebased onto main after the documentation here is merged, and then to update the documentation in your branch.

If we change the documentation now, we will be adding documentation for features, which are not yet included in the mainline, which would be incorrect.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @vaniobegic here. @adriananeci , you would want to add/update the documentation as part of #16846

nitishfy
nitishfy approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ishitasequeira
ishitasequeira approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@ishitasequeira ishitasequeira merged commit bd322fe into argoproj:master Dec 11, 2024
28 checks passed
GuySaar8 pushed a commit to GuySaar8/argo-cd that referenced this pull request Dec 12, 2024
@thecooldrop @GuySaar8
chore: Improve the documentation regarding the selection of Applicati…
ac0ab58 
…on by Sync Windows (argoproj#21093)

Signed-off-by: TheCoolDrop <vanio.begic123@gmail.com>
@Sebast1aan Sebast1aan mentioned this pull request Dec 20, 2024
Closed
dudo pushed a commit to dudo/argo-cd that referenced this pull request Jan 18, 2025
@thecooldrop @dudo
chore: Improve the documentation regarding the selection of Applicati…
4ca49c2 
…on by Sync Windows (argoproj#21093)

Signed-off-by: TheCoolDrop <vanio.begic123@gmail.com>
Signed-off-by: Brett C. Dudo <brett@dudo.io>
revitalbarletz pushed a commit to revitalbarletz/argo-cd that referenced this pull request Jan 20, 2025
@thecooldrop @revitalbarletz
chore: Improve the documentation regarding the selection of Applicati…
df0f7c4 
…on by Sync Windows (argoproj#21093)

Signed-off-by: TheCoolDrop <vanio.begic123@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishitasequeira ishitasequeira ishitasequeira approved these changes

@reggie-k reggie-k reggie-k approved these changes

@nitishfy nitishfy nitishfy approved these changes

+3 more reviewers

@adriananeci adriananeci adriananeci left review comments

@vaniobegic vaniobegic vaniobegic left review comments

@andrii-korotkov-verkada andrii-korotkov-verkada andrii-korotkov-verkada approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ready-for-review An approver should give a final review and merge the PR
Projects
Argo CD Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@thecooldrop @reggie-k @adriananeci @ishitasequeira @nitishfy @vaniobegic @andrii-korotkov-verkada