Skip to content

Conversation

amine7536
Copy link
Contributor

@amine7536 amine7536 commented Dec 4, 2024

Signed-off-by: Amine Benseddik amine.benseddik@gmail.com

The command argocd admin proj generate-spec examples are wrong:

$ argocd admin proj generate-spec --help
Generate declarative config for a project

Usage:
  argocd admin proj generate-spec PROJECT [flags]

Examples:
  # Generate a YAML configuration for a project named "myproject"
  argocd admin projects generate-spec myproject
  
  # Generate a JSON configuration for a project named "anotherproject" and specify an output file
  argocd admin projects generate-spec anotherproject --output json --file config.json
  
  # Generate a YAML configuration for a project named "someproject" and write it back to the input file
  argocd admin projects generate-spec someproject --inline

It should be proj instead of projects.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: Amine Benseddik <amine.benseddik@gmail.com>
@amine7536 amine7536 requested review from a team as code owners December 4, 2024 14:21
Copy link

bunnyshell bot commented Dec 4, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@todaywasawesome todaywasawesome enabled auto-merge (squash) December 4, 2024 15:13
@todaywasawesome todaywasawesome merged commit eb1bb83 into argoproj:master Dec 9, 2024
29 checks passed
dudo pushed a commit to dudo/argo-cd that referenced this pull request Jan 18, 2025
Signed-off-by: Amine Benseddik <amine.benseddik@gmail.com>
Signed-off-by: Brett C. Dudo <brett@dudo.io>
revitalbarletz pushed a commit to revitalbarletz/argo-cd that referenced this pull request Jan 20, 2025
Signed-off-by: Amine Benseddik <amine.benseddik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants