Skip to content

Conversation

surajyadav1108
Copy link
Contributor

@surajyadav1108 surajyadav1108 commented Nov 24, 2024

Added Moment which has been used throught argocd to calculate timestamp difference
with outputs like

a few seconds
N minutes
N hours

Closes #20913

Screenshot 2024-11-24 114308

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>
@surajyadav1108 surajyadav1108 requested a review from a team as a code owner November 24, 2024 06:28
Copy link

bunnyshell bot commented Nov 24, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@andrii-korotkov-verkada andrii-korotkov-verkada added the ready-for-review An approver should give a final review and merge the PR label Nov 24, 2024
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, and it behaves well in Bunnyshell. Thanks!

@crenshaw-dev crenshaw-dev merged commit 1120a08 into argoproj:master Nov 24, 2024
29 checks passed
adriananeci pushed a commit to adriananeci/argo-cd that referenced this pull request Dec 4, 2024
Signed-off-by: Surajyadav <harrypotter1108@gmail.com>
Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review An approver should give a final review and merge the PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add timing info to container state UI
3 participants