feat(ui): add keydown event to the pod dropdown menu #20996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❗ Preview Environment undeploy from Bunnyshell failedSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
ee77d25 to
2eac281
Compare
| @@ -656,13 +656,25 @@ export function renderResourceMenu( | |||
| {items.map((item, i) => ( | |||
| <li | |||
| className={classNames('application-details__action-menu', {disabled: item.disabled})} | |||
| tabIndex={0} | |||
There was a problem hiding this comment.
Why is it always 0? Should it be i?
There was a problem hiding this comment.
tabindex="0" means that the element should be focusable in sequential keyboard navigation, after any positive tabindex values. The focus navigation order of these elements is defined by their order in the document source.
linghaoSu
reviewed
Nov 29, 2024
| onKeyDown={e => { | ||
| if (e.keyCode === 13 || e.key === 'Enter') { | ||
| e.stopPropagation(); | ||
| if (!item.disabled) { |
There was a problem hiding this comment.
If the current button is disabled, I think it shouldn't receive focus. Maybe we should just skip it.🤔
There was a problem hiding this comment.
This is indeed the better way!
|
Looks good, just fix DCO. |
Signed-off-by: vivian.zhang <vivian.zhang@daocloud.io>
Signed-off-by: vivian.zhang <vivian.zhang@daocloud.io>
56bf1c7 to
7dba696
Compare
linghaoSu
approved these changes
Dec 4, 2024
surajyadav1108
approved these changes
Dec 21, 2024
DCO has been fixed. |
andrii-korotkov-verkada
approved these changes
Jan 1, 2025
bashlion
approved these changes
Jan 5, 2025
agaudreault
approved these changes
May 8, 2025
LyhengTep
pushed a commit
to LyhengTep/argo-cd
that referenced
this pull request
May 10, 2025
Signed-off-by: vivian.zhang <vivian.zhang@daocloud.io>
ranakan19
pushed a commit
to ranakan19/argo-cd
that referenced
this pull request
May 20, 2025
Signed-off-by: vivian.zhang <vivian.zhang@daocloud.io> Signed-off-by: Kanika Rana <krana@redhat.com>
olivergondza
pushed a commit
to olivergondza/argo-cd
that referenced
this pull request
May 20, 2025
Signed-off-by: vivian.zhang <vivian.zhang@daocloud.io> Signed-off-by: Oliver Gondža <ogondza@gmail.com>
tylerrosnett
pushed a commit
to StateFarmIns/argo-cd
that referenced
this pull request
May 27, 2025
Signed-off-by: vivian.zhang <vivian.zhang@daocloud.io>
chansuke
pushed a commit
to chansuke/argo-cd
that referenced
this pull request
Jun 4, 2025
Signed-off-by: vivian.zhang <vivian.zhang@daocloud.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add keydown event to the pod dropdown menu
Fixes #20829
Before: No response to pressing the tab menu after clicking an item in the pod menu
After: Click on an item in the pod menu and press menu focus
Action Details Focus:
Action Delete Focus:
Checklist: