Skip to content

fix: add github fields to listrepositories #20991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix: add github fields to listrepositories #20991

merged 1 commit into from
Dec 11, 2024

Conversation

blakepettersson
Copy link
Member

@blakepettersson blakepettersson commented Nov 28, 2024 •
edited
Loading

This fixes a regression in 2.12. Before 2.12 githubAppInstallationID, githubAppID and githubAppID were returned, but with 2.12 the repo is retrieved with ListRepositories, which does not include those fields.

To fix this, add those missing fields to ListRepositories.

Cherry-pick for 2.12 and 2.13.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Nov 28, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@blakepettersson blakepettersson changed the title fix: return all fields in repo.get fix: add github fields to listrepositories Nov 28, 2024
@blakepettersson
fix: add missing fields in listrepositories
2ef7b49 
This fixes a regression in 2.12. Before 2.12 githubAppInstallationID,
`githubAppID` and `gitHubAppEnterpriseBaseURL` were returned, but with
2.12 the repo is retrieved with getRepositories`, which does not
include those fields.

To fix this, add those missing fields to `ListRepositories`.

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
@blakepettersson blakepettersson force-pushed the fix/get-repo-2.12-regression branch from 0aa252e to 2ef7b49 Compare November 28, 2024 17:28
@blakepettersson blakepettersson marked this pull request as ready for review November 28, 2024 17:29
@blakepettersson blakepettersson requested a review from a team as a code owner November 28, 2024 17:29
@blakepettersson blakepettersson mentioned this pull request Nov 28, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Nov 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.02%. Comparing base (e8d5265) to head (2ef7b49).
Report is 487 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #20991   +/-   ##
=======================================
  Coverage   55.02%   55.02%           
=======================================
  Files         324      324           
  Lines       55456    55469   +13     
=======================================
+ Hits        30512    30523   +11     
- Misses      22323    22331    +8     
+ Partials     2621     2615    -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrii-korotkov-verkada andrii-korotkov-verkada added the ready-for-review An approver should give a final review and merge the PR label Nov 29, 2024
@CefBoud CefBoud mentioned this pull request Nov 30, 2024
Closed
6 tasks
ishitasequeira
ishitasequeira approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@ishitasequeira ishitasequeira merged commit 2fe9a22 into argoproj:master Dec 11, 2024
36 checks passed
@blakepettersson blakepettersson deleted the fix/get-repo-2.12-regression branch December 11, 2024 09:47
@blakepettersson
Copy link
Member Author

/cherry-pick release-2.12

@blakepettersson
Copy link
Member Author

/cherry-pick release-2.13

@gcp-cherry-pick-bot GCP Cherry-Pick Bot
Copy link

Cherry-pick failed with Merge error 2fe9a220dda581efb9cf2d9110b7f9d02c705439 into temp-cherry-pick-6cdd10-release-2.12

@gcp-cherry-pick-bot GCP Cherry-Pick Bot
Copy link

Cherry-pick failed with Merge error 2fe9a220dda581efb9cf2d9110b7f9d02c705439 into temp-cherry-pick-6cdd10-release-2.13

blakepettersson added a commit to blakepettersson/argo-cd that referenced this pull request Dec 11, 2024
@blakepettersson
fix: add missing fields in listrepositories (argoproj#20991)
f8caf52 
This fixes a regression in 2.12. Before 2.12 githubAppInstallationID,
`githubAppID` and `gitHubAppEnterpriseBaseURL` were returned, but with
2.12 the repo is retrieved with getRepositories`, which does not
include those fields.

To fix this, add those missing fields to `ListRepositories`.

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
blakepettersson added a commit to blakepettersson/argo-cd that referenced this pull request Dec 11, 2024
@blakepettersson
fix: add missing fields in listrepositories (argoproj#20991)
430262d 
This fixes a regression in 2.12. Before 2.12 githubAppInstallationID,
`githubAppID` and `gitHubAppEnterpriseBaseURL` were returned, but with
2.12 the repo is retrieved with getRepositories`, which does not
include those fields.

To fix this, add those missing fields to `ListRepositories`.

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
blakepettersson added a commit that referenced this pull request Dec 11, 2024
@blakepettersson
fix: add missing fields in listrepositories (#20991) (#21129)
b6af657 
This fixes a regression in 2.12. Before 2.12 githubAppInstallationID,
`githubAppID` and `gitHubAppEnterpriseBaseURL` were returned, but with
2.12 the repo is retrieved with getRepositories`, which does not
include those fields.

To fix this, add those missing fields to `ListRepositories`.

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
blakepettersson added a commit that referenced this pull request Dec 11, 2024
@blakepettersson
fix: add missing fields in listrepositories (#20991) (#21128)
7642db8 
This fixes a regression in 2.12. Before 2.12 githubAppInstallationID,
`githubAppID` and `gitHubAppEnterpriseBaseURL` were returned, but with
2.12 the repo is retrieved with getRepositories`, which does not
include those fields.

To fix this, add those missing fields to `ListRepositories`.

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
GuySaar8 pushed a commit to GuySaar8/argo-cd that referenced this pull request Dec 12, 2024
@blakepettersson @GuySaar8
fix: add missing fields in listrepositories (argoproj#20991)
b54875b 
This fixes a regression in 2.12. Before 2.12 githubAppInstallationID,
`githubAppID` and `gitHubAppEnterpriseBaseURL` were returned, but with
2.12 the repo is retrieved with getRepositories`, which does not
include those fields.

To fix this, add those missing fields to `ListRepositories`.

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
dudo pushed a commit to dudo/argo-cd that referenced this pull request Jan 18, 2025
@blakepettersson @dudo
fix: add missing fields in listrepositories (argoproj#20991)
7401b43 
This fixes a regression in 2.12. Before 2.12 githubAppInstallationID,
`githubAppID` and `gitHubAppEnterpriseBaseURL` were returned, but with
2.12 the repo is retrieved with getRepositories`, which does not
include those fields.

To fix this, add those missing fields to `ListRepositories`.

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Brett C. Dudo <brett@dudo.io>
revitalbarletz pushed a commit to revitalbarletz/argo-cd that referenced this pull request Jan 20, 2025
@blakepettersson @revitalbarletz
fix: add missing fields in listrepositories (argoproj#20991)
aedd5d5 
This fixes a regression in 2.12. Before 2.12 githubAppInstallationID,
`githubAppID` and `gitHubAppEnterpriseBaseURL` were returned, but with
2.12 the repo is retrieved with getRepositories`, which does not
include those fields.

To fix this, add those missing fields to `ListRepositories`.

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishitasequeira ishitasequeira ishitasequeira approved these changes

+3 more reviewers

@CefBoud CefBoud CefBoud approved these changes

@the-technat the-technat the-technat approved these changes

@andrii-korotkov-verkada andrii-korotkov-verkada andrii-korotkov-verkada approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ready-for-review An approver should give a final review and merge the PR
Projects
Argo CD Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@blakepettersson @CefBoud @the-technat @ishitasequeira @andrii-korotkov-verkada