feat: Add images to resources in sync result #20896 #20954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❗ Preview Environment undeploy from Bunnyshell failedSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
|
The error is |
|
You have to add |
Yeah for testing locally that works, but I'd rather not commit that |
fbbe33f to
7c0c69b
Compare
Aaron-9900
commented
Feb 19, 2025
| @@ -184,7 +184,7 @@ func ResourceResultIs(result ResourceResult) Expectation { | |||
| return func(c *Consequences) (state, string) { | |||
| results := c.app().Status.OperationState.SyncResult.Resources | |||
| for _, res := range results { | |||
| if *res == result { | |||
| if reflect.DeepEqual(*res, result) { | |||
There was a problem hiding this comment.
Necessary because now we have an array in the result
6ac6a18 to
b00d56d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #20954 +/- ##
==========================================
- Coverage 60.01% 59.98% -0.04%
==========================================
Files 343 343
Lines 57888 57890 +2
==========================================
- Hits 34744 34726 -18
- Misses 20358 20381 +23
+ Partials 2786 2783 -3 ☔ View full report in Codecov by Sentry. |
218ca88 to
1b82a2f
Compare
Aaron-9900
commented
Mar 4, 2025
af81365 to
d754884
Compare
c9f19d8 to
c605834
Compare
c605834 to
584235f
Compare
crenshaw-dev
approved these changes
May 27, 2025
Signed-off-by: Aaron Hoffman <31711338+Aaron-9900@users.noreply.github.com>
Signed-off-by: Aaron Hoffman <31711338+Aaron-9900@users.noreply.github.com>
Signed-off-by: Aaron Hoffman <31711338+Aaron-9900@users.noreply.github.com>
06b31f4 to
7fcabf5
Compare
chansuke
pushed a commit
to chansuke/argo-cd
that referenced
this pull request
Jun 4, 2025
…#20954) Signed-off-by: Aaron Hoffman <31711338+Aaron-9900@users.noreply.github.com>
dsuhinin
pushed a commit
to dsuhinin/argo-cd
that referenced
this pull request
Jun 16, 2025
…#20954) Signed-off-by: Aaron Hoffman <31711338+Aaron-9900@users.noreply.github.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
dsuhinin
pushed a commit
to dsuhinin/argo-cd
that referenced
this pull request
Jun 16, 2025
…#20954) Signed-off-by: Aaron Hoffman <31711338+Aaron-9900@users.noreply.github.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #20896
Docs: #20896 docs | Add notifications examples section ✅
GitOps: feat: return images from resources when sync occurs ✅
Checklist: