Skip to content

feat(ui): Added toggle for fullname of resources in application-details-tree. #20812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 8, 2025
Merged

feat(ui): Added toggle for fullname of resources in application-details-tree. #20812

merged 8 commits into from
May 8, 2025

Conversation

surajyadav1108
Copy link
Contributor

@surajyadav1108 surajyadav1108 commented Nov 16, 2024 •
edited
Loading

As discussed in issue.

Closses #19110

togglenode-name.mp4

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@surajyadav1108
added-resource-name-toggle
44cb927 
Signed-off-by: Surajyadav <harrypotter1108@gmail.com>
@surajyadav1108 surajyadav1108 requested a review from a team as a code owner November 16, 2024 19:15
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Nov 16, 2024 •
edited
Loading

❗ Preview Environment undeploy from Bunnyshell failed

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🚀 /bns:deploy to redeploy the environment
  • ❌ /bns:delete to try again to remove the environment

@surajyadav1108 surajyadav1108 changed the title feat(ui) : Added toggle for fullname of resources in application-details-tree. feat(ui): Added toggle for fullname of resources in application-details-tree. Nov 16, 2024
@surajyadav1108
changed-f-to-F
37dbc6f 
Signed-off-by: Surajyadav <harrypotter1108@gmail.com>
@surajyadav1108
removed-height-unset-added-title-fullname
ef276c6 
Signed-off-by: Surajyadav <harrypotter1108@gmail.com>
@surajyadav1108
Copy link
Contributor Author

surajyadav1108 commented Nov 21, 2024 •
edited
Loading

A little update, as a suggestion by @ba32107

added the CSS which would show the fullname for application title

and also removed the

height: unset !important

as it was causing issue with grouping node button like this

Screenshot 2024-11-21 175757

now after the removal it works fine with the fullname toggle

toggle-fix.mp4

@surajyadav1108 surajyadav1108 mentioned this pull request Dec 4, 2024
Closed
6 tasks
@agaudreault agaudreault enabled auto-merge (squash) May 7, 2025 23:56
@agaudreault agaudreault disabled auto-merge May 7, 2025 23:57
@agaudreault
fix merge issue
d79ec9a 
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
@agaudreault agaudreault enabled auto-merge (squash) May 7, 2025 23:59
@agaudreault agaudreault merged commit 3f3ac06 into argoproj:master May 8, 2025
22 checks passed
LyhengTep pushed a commit to LyhengTep/argo-cd that referenced this pull request May 10, 2025
@surajyadav1108 @agaudreault @LyhengTep
feat(ui): add toggle for fullname of resources in application-details…
823d838 
…-tree (argoproj#20812)

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
ranakan19 pushed a commit to ranakan19/argo-cd that referenced this pull request May 20, 2025
@surajyadav1108 @agaudreault @ranakan19
feat(ui): add toggle for fullname of resources in application-details…
06abf01 
…-tree (argoproj#20812)

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Kanika Rana <krana@redhat.com>
olivergondza pushed a commit to olivergondza/argo-cd that referenced this pull request May 20, 2025
@surajyadav1108 @agaudreault @olivergondza
feat(ui): add toggle for fullname of resources in application-details…
997898c 
…-tree (argoproj#20812)

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
tylerrosnett pushed a commit to StateFarmIns/argo-cd that referenced this pull request May 27, 2025
@surajyadav1108 @agaudreault @tylerrosnett
feat(ui): add toggle for fullname of resources in application-details…
f0c64e9 
…-tree (argoproj#20812)

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
chansuke pushed a commit to chansuke/argo-cd that referenced this pull request Jun 4, 2025
@surajyadav1108 @agaudreault @chansuke
feat(ui): add toggle for fullname of resources in application-details…
e4739c0 
…-tree (argoproj#20812)

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agaudreault agaudreault agaudreault approved these changes

@andrii-korotkov-verkada andrii-korotkov-verkada Awaiting requested review from andrii-korotkov-verkada

Assignees
No one assigned
Labels
ready-for-review
Projects
Argo CD Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@surajyadav1108 @agaudreault @andrii-korotkov-verkada