Skip to content

chore: use testify instead of testing.Fatal or testing.Error in util #20751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2024
Merged

chore: use testify instead of testing.Fatal or testing.Error in util #20751

merged 1 commit into from
Nov 11, 2024

Conversation

mmorel-35
Copy link
Contributor

Description

  • uses testify instead of testing.Fatal or testing.Error in util

@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Nov 11, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@mmorel-35 mmorel-35 force-pushed the testifier/util branch 2 times, most recently from 911fcc4 to 5470902 Compare November 11, 2024 13:13
@mmorel-35 mmorel-35 marked this pull request as ready for review November 11, 2024 13:22
@mmorel-35 mmorel-35 requested a review from a team as a code owner November 11, 2024 13:22
@mmorel-35
chore: use testify instead of testing.Fatal or testing.Error in util
53c2dc4 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@codecov Codecov
Copy link

codecov bot commented Nov 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.18%. Comparing base (b39f3b1) to head (53c2dc4).
Report is 365 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #20751      +/-   ##
==========================================
+ Coverage   55.12%   55.18%   +0.06%     
==========================================
  Files         324      324              
  Lines       55256    55256              
==========================================
+ Hits        30458    30493      +35     
+ Misses      22184    22157      -27     
+ Partials     2614     2606       -8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pasha-codefresh pasha-codefresh merged commit a6cce1d into argoproj:master Nov 11, 2024
27 checks passed
@mmorel-35 mmorel-35 deleted the testifier/util branch November 11, 2024 16:00
adriananeci pushed a commit to adriananeci/argo-cd that referenced this pull request Dec 4, 2024
@mmorel-35 @adriananeci
chore: use testify instead of testing.Fatal or testing.Error in util (a…
c24a7e7 
…rgoproj#20751)

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasha-codefresh pasha-codefresh pasha-codefresh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmorel-35 @pasha-codefresh