Skip to content

Conversation

mmorel-35
Copy link
Contributor

Description

  • uses testify instead of testing.Fatal or testing.Error in cmd

@mmorel-35 mmorel-35 requested a review from a team as a code owner November 11, 2024 11:36
Copy link

bunnyshell bot commented Nov 11, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@mmorel-35 mmorel-35 marked this pull request as draft November 11, 2024 11:58
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 force-pushed the testifier/cmd branch 3 times, most recently from fa62a82 to 6e06288 Compare November 11, 2024 13:14
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 marked this pull request as ready for review November 11, 2024 13:58
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.09%. Comparing base (b39f3b1) to head (df45a89).
Report is 365 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20750      +/-   ##
==========================================
- Coverage   55.12%   55.09%   -0.03%     
==========================================
  Files         324      324              
  Lines       55256    55256              
==========================================
- Hits        30458    30446      -12     
- Misses      22184    22191       +7     
- Partials     2614     2619       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pasha-codefresh pasha-codefresh merged commit 6b3e532 into argoproj:master Nov 11, 2024
27 checks passed
@mmorel-35 mmorel-35 deleted the testifier/cmd branch November 11, 2024 15:59
adriananeci pushed a commit to adriananeci/argo-cd that referenced this pull request Dec 4, 2024
…rgoproj#20750)

* chore: use testify instead of testing.Fatal or testing.Error in cmd

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* chore: use testify instead of testing.Fatal or testing.Error in cmd

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

---------

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants